Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data explorer breaks ctrl-tab #2959

Closed
timmclean opened this issue Aug 26, 2014 · 4 comments
Closed

Data explorer breaks ctrl-tab #2959

timmclean opened this issue Aug 26, 2014 · 4 comments
Assignees
Milestone

Comments

@timmclean
Copy link

The data explorer autocomplete overrides the browser's ctrl-tab and ctrl-shift-tab (Firefox 31 on Ubuntu).

@neumino
Copy link
Member

neumino commented Aug 26, 2014

Hum, that's interesting.

It can confirm that the data explorer prevents Ctrl+Tab on Firefox to switch tab. It doesn't prevent Chrome from switching tab though.

Thanks @timmclean for reporting it, I'll take a look at it.

@neumino neumino added this to the 1.14.x milestone Aug 26, 2014
@neumino neumino self-assigned this Aug 26, 2014
@timmclean
Copy link
Author

np! thanks.

@neumino
Copy link
Member

neumino commented Sep 29, 2014

Firefox 32 switches tab with ctrl+tab, but not firefox 31.
Things work fine on Chromium 37 too.

There is a fix in branch michel_2959_ctrl_tab -- we basically catch tab on the data explorer, but not ctrl+tab.

In review 2151 assigned to @mglukhovsky

@neumino neumino modified the milestones: 1.15.x, 1.14.x Sep 29, 2014
@neumino
Copy link
Member

neumino commented Sep 29, 2014

Merged in next as 42c8d24
Cherry-picked in v1.15.x as 6a4c635

Ship 1.15.1

@neumino neumino closed this as completed Sep 29, 2014
@AtnNn AtnNn modified the milestones: 1.15.x, 1.15.1 Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants