Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table created with durability='soft' shows as having hard durability in rethinkdb admin ls tables #3128

Closed
bigtree3131 opened this issue Oct 1, 2014 · 13 comments
Assignees
Labels
Milestone

Comments

@bigtree3131
Copy link

running the following:
r.db('BenchCalcs1').tableCreate('temp', {durability:'soft'})

and:
rethinkdb admin ls tables --long -j 10.1.40.16:29015 | grep temp

produces:
97f02f89-fca1-45ce-a9d2-786cb44c6221 BenchCalcs1 temp 1 1 0000000-0000-0000-0000-000000000000 db806c1e-db2f-4c76-964d-21df1c3fe871 hard

@coffeemug
Copy link
Contributor

I'm able to reproduce on OS X in 1.15. Could someone grab this?

@neumino
Copy link
Member

neumino commented Oct 1, 2014

The web ui still lets you create table with soft durability.
The tables created through the Python/JavaScript drivers seems to always be in hard durability.

@bigtree3131
Copy link
Author

When I created 'temp', it was via the web UI

@neumino
Copy link
Member

neumino commented Oct 1, 2014

@bigtree3131 -- sorry, I wasn't really clear. When I wrote via the web interface, I meant via the button "Add table" on tables view (not on the data explorer).

The data explorer relies on the JavaScript driver, whereas the "Add table" button uses another mechanism (it directly writes to the semilattice).

@bigtree3131
Copy link
Author

Gotcha -- from eye balling my tables it appears that any table created in 1.15 appears with hard durability -- for pre-1.15, it appears that tables created with a pkey other than 'id' allows you to set the durability to 'soft'...however, if the pkey is the default 'id', then specifying durability has no effect.

Again, these are just my observations but might a good place to start looking.

@danielmewes
Copy link
Member

Did we remove the per-table durability setting already? I thought this would only happen as part of the ReQL admin changes.
So is this a regression?

@danielmewes
Copy link
Member

Looking into this...

@danielmewes danielmewes self-assigned this Oct 1, 2014
@danielmewes danielmewes added this to the 1.15.x milestone Oct 1, 2014
@danielmewes
Copy link
Member

It seems that this has already been broken in 1.14

@coffeemug
Copy link
Contributor

Hi @danielmewes -- welcome back!

Did we remove the per-table durability setting already?

No. We also decided not to remove it even in the reql-admin branch, as many people mentioned they use this feature quite heavily. So it looks like a regression that we should fix.

@danielmewes
Copy link
Member

Fixed in branch daniel_3128, in code review 2164 by @timmaxw .

@danielmewes
Copy link
Member

Fixed in v1.15.x and next 7c7c2c4

The fix will ship with RethinkDB 1.15.1.

@bigtree3131 Note that this isn't just a problem with rethinkdb admin, but the tables will actually use hard durability due to this bug, even when created with durabilty: 'soft'. I recommend creating tables through the web UI if you need soft default durability for now.

@danielmewes
Copy link
Member

@coffeemug @AtnNn Do you think this is worth preparing a 1.15.1 point release for?

@AtnNn
Copy link
Member

AtnNn commented Oct 1, 2014

Yes. I'll get the ball rolling in my court.

@AtnNn AtnNn modified the milestones: 1.15.x, 1.15.1 Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants