New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table created with durability='soft' shows as having hard durability in rethinkdb admin ls tables #3128
Comments
I'm able to reproduce on OS X in 1.15. Could someone grab this? |
The web ui still lets you create table with soft durability. |
When I created 'temp', it was via the web UI |
@bigtree3131 -- sorry, I wasn't really clear. When I wrote via the web interface, I meant via the button "Add table" on tables view (not on the data explorer). The data explorer relies on the JavaScript driver, whereas the "Add table" button uses another mechanism (it directly writes to the semilattice). |
Gotcha -- from eye balling my tables it appears that any table created in 1.15 appears with hard durability -- for pre-1.15, it appears that tables created with a pkey other than 'id' allows you to set the durability to 'soft'...however, if the pkey is the default 'id', then specifying durability has no effect. Again, these are just my observations but might a good place to start looking. |
Did we remove the per-table durability setting already? I thought this would only happen as part of the ReQL admin changes. |
Looking into this... |
It seems that this has already been broken in 1.14 |
Hi @danielmewes -- welcome back!
No. We also decided not to remove it even in the reql-admin branch, as many people mentioned they use this feature quite heavily. So it looks like a regression that we should fix. |
Fixed in branch daniel_3128, in code review 2164 by @timmaxw . |
Fixed in v1.15.x and next 7c7c2c4 The fix will ship with RethinkDB 1.15.1. @bigtree3131 Note that this isn't just a problem with |
@coffeemug @AtnNn Do you think this is worth preparing a 1.15.1 point release for? |
Yes. I'll get the ball rolling in my court. |
running the following:
r.db('BenchCalcs1').tableCreate('temp', {durability:'soft'})
and:
rethinkdb admin ls tables --long -j 10.1.40.16:29015 | grep temp
produces:
97f02f89-fca1-45ce-a9d2-786cb44c6221 BenchCalcs1 temp 1 1 0000000-0000-0000-0000-000000000000 db806c1e-db2f-4c76-964d-21df1c3fe871 hard
The text was updated successfully, but these errors were encountered: