Making geo terms non-deterministic prevents us from using them in indexes

[mlucy]

This seems like a major problem. @danielmewes, any thoughts?

irb(main):040:0> r.table('test').index_create('geo', geo:true){|row| r.point(row['longitude'], row['latitude'])}.run
RethinkDB::RqlRuntimeError: Could not prove function deterministic.  Index functions must be deterministic.

[danielmewes]

We could definitely make the r.point() constructor deterministic again, since it doesn't perform any form of complex math (it only compares the coordinates to check that they are in range). Do you think that would help?

The same wouldn't work as easily for the other geo constructors because they use operations that are potentially suspectible to rounding errors (such as intersection tests).

[mlucy]

That would definitely help, since points are probably 99% of what people are going to want to compute in an index function.

[danielmewes]

Fix in branch daniel_3287, CR 2277

[danielmewes]

Fixed for r.point() in v1.15.x and next by 050963d