Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion arrow goes out of bounds if you have excessive whitespace #529

Closed
mglukhovsky opened this issue Mar 25, 2013 · 2 comments
Closed

Suggestion arrow goes out of bounds if you have excessive whitespace #529

mglukhovsky opened this issue Mar 25, 2013 · 2 comments
Assignees
@neumino
Milestone
1.5

Comments

@mglukhovsky
Copy link
Member

Should be an easy fix, just makes sure the CSS for the position arrow doesn't exceed the width of the data explorer.
@ghost ghost assigned neumino Mar 25, 2013
neumino pushed a commit that referenced this issue Mar 28, 2013
Update codemirror. Related to #529
f3395c7
@neumino
Copy link
Member

neumino commented Mar 28, 2013

So it's a webkit bug. It works perfectly fine in Firefox.
Codemirror pushed a fix for that, see codemirror/codemirror5#1362

Code review 310.

neumino pushed a commit that referenced this issue Mar 29, 2013
Update codemirror. Related to #529
5ad1ece
@neumino
Copy link
Member

neumino commented May 2, 2013

It has been merged in next a long time ago.
I just forgot to close this issue.

@neumino neumino closed this as completed May 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neumino neumino

Labels
None yet
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@mglukhovsky @neumino