Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We don't error when you coerce a non-Unicode binary blob to a string #5536

Closed
mlucy opened this issue Mar 17, 2016 · 3 comments
Closed

We don't error when you coerce a non-Unicode binary blob to a string #5536

mlucy opened this issue Mar 17, 2016 · 3 comments
Labels
tp:bug
Milestone
2.3

Comments

@mlucy
Copy link
Member

mlucy commented Mar 17, 2016

Even if it results in a string that we would have rejected if you tried to specify it literally, like "\xFF". It looks like we'll also happily store these invalid strings in documents, and even use them as primary keys.
@mlucy mlucy added the tp:bug label Mar 17, 2016
@mlucy mlucy added this to the 2.2.x milestone Mar 17, 2016
@danielmewes danielmewes modified the milestones: 2.3, 2.2.x Mar 18, 2016
@danielmewes
Copy link
Member

Moving into 2.3. 2.3 isn't that far away, and fixing this can potentially break queries.

@nighelles
Copy link

I have a fix in nighelles/5536

nighelles pushed a commit that referenced this issue Mar 24, 2016
Small fix for #5536
4b922e6 
OTS by @danielmewes
@nighelles
Copy link

This is in next.

jjqq2013 pushed a commit to sjitech/rethinkdb that referenced this issue Mar 26, 2016
@jjqq2013
Small fix for rethinkdb#5536
e97870d 
OTS by @danielmewes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tp:bug
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
3 participants
@danielmewes @nighelles @mlucy