Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of references to walkthrough.jpg #68

Closed
jdoliner opened this issue Nov 16, 2012 · 6 comments
Closed

Get rid of references to walkthrough.jpg #68

jdoliner opened this issue Nov 16, 2012 · 6 comments
Milestone

Comments

@jdoliner
Copy link
Contributor

Currently our html files contain references to the old walkthrough images which don't actually exist on the server. There's no exposed links but this does lead to error messages if someone crawls the site. Generally I think it's poor form the have links to things that don't exists even if they're concealed.

A much lesser issue is that we get the same thing robots.txt ... I actually don't even consider that to be a real issue.

@coffeemug
Copy link
Contributor

Or we could actually add a walkthrough, not that the UI is complete.

@neumino
Copy link
Member

neumino commented Jan 5, 2013

Should we get rid of the current (dead) walkthrough code?

I don't think the web UI is really hard to understand so I'm not sure we need one, but if we have to do a walkthrough, I think an overlay would be better than a slideshow.

@jdoliner
Copy link
Contributor Author

jdoliner commented Jan 5, 2013

I think honestly if we need a walkthrough to explain a UI we're doing
something wrong. And people seem to get and like the UI without one so I my
vote is to just nix this idea altogether.

On Fri, Jan 4, 2013 at 6:10 PM, Michel notifications@github.com wrote:

Should we get rid of the current (dead) walkthrough code?

I don't think the web UI is really hard to understand so I'm not sure we
need one, but if we have to do a walkthrough, I think an overlay would be
better than a slideshow.


Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-11907784.

@coffeemug
Copy link
Contributor

I also vote to get rid of the code, for the following reasons:

  • I don't think a walkthrough is a bad idea per se, a really nice UI + a simple introductory walkthrough can still be really nice. But I do think that to maintain the level of polish we have now, we'd have to do a well thought-out interactive mini-tutorial, not a slideshow, and the code we have now is useless for that.
  • Considering how much people like the UI, and all the other stuff we'd like to do, it's unlikely this project will get done any time soon. So the code will bitrot even further.
  • It's frankly not very difficult to put back in if we ever need it.

@neumino
Copy link
Member

neumino commented Jan 18, 2013

Done in commit 807bdbe
Code review 159.

I'll close when the review will be completed and the code merged in next.

@neumino
Copy link
Member

neumino commented Jan 19, 2013

Merged in e228168
Code review 159

@neumino neumino closed this as completed Jan 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants