Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeOf is broken in JS driver #704

Closed
coffeemug opened this issue Apr 24, 2013 · 2 comments
Closed

typeOf is broken in JS driver #704

coffeemug opened this issue Apr 24, 2013 · 2 comments
Assignees
@wmrowan
Milestone
1.5

Comments

@coffeemug
Copy link
Contributor

There are a couple of problems with typeOf.

  1. We should ensure it doesn't accept any arguments (e.g., I can currently say r.expr(1).typeOf('foo')). This should throw.
  2. In JS and Python, we should also support r.typeOf(x) syntax
@ghost ghost assigned wmrowan Apr 24, 2013
@wmrowan
Copy link
Contributor

wmrowan commented Apr 24, 2013

It doesn't look there there are any comprehensive tests of typeOf in the polyglot test.

wmrowan added a commit that referenced this issue Apr 26, 2013
@wmrowan
adds polyglot tests for typeof, see #704
0968960
@wmrowan
Copy link
Contributor

wmrowan commented Apr 26, 2013

review 437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmrowan wmrowan

Labels
None yet
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@coffeemug @wmrowan