Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import_export.rb in next defaults to sending batches of size 2 (?) #782

Closed
mlucy opened this issue May 10, 2013 · 2 comments
Closed

import_export.rb in next defaults to sending batches of size 2 (?) #782

mlucy opened this issue May 10, 2013 · 2 comments
Assignees
@mlucy
Labels
tp:enhancement
Milestone
1.5

Comments

@mlucy
Copy link
Member

mlucy commented May 10, 2013

We should probably pick a higher batch size and make it configurable.
@ghost ghost assigned mlucy May 10, 2013
mlucy added a commit that referenced this issue May 10, 2013
@mlucy
improved batching and added verbose option to import_export.rb (c.f. …
24a9d2c 
…Issue #782)
@mlucy
Copy link
Member Author

mlucy commented May 10, 2013

This is in code-review 520 by @AtnNn . I decided not to make the batch size configurable and instead to add a crude heuristic to use small batch sizes when inserting large rows. (I think a crude heuristic is all we need here.)

@mlucy
Copy link
Member Author

mlucy commented May 10, 2013

This is in next.

@mlucy mlucy closed this as completed May 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlucy mlucy

Labels
tp:enhancement
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
1 participant
@mlucy