Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False values in a document show up as blank in the tree view. #790

Closed
mglukhovsky opened this issue May 13, 2013 · 3 comments · Fixed by ferreiramarcelo/rethinkdb#3
Closed
Assignees
Milestone

Comments

@mglukhovsky
Copy link
Member

As reported by shanebo on IRC:

shanebo: mglukhov r.table('tasks').insert({text: 'hello world', starred: false})
mglukhov: ok, i'm going to insert that document into a new table via the data explorer, correct?
shanebo: correct
        then get tasks table
mglukhov: what do you expect / what do you see?
shanebo: and you'll see this: http://cl.ly/image/1h0z1D32342I
        mglukhov see how the starred field has no output?
        even though it was set to false

False values don't render correctly-- this should be an easy fix for @neumino: http://cl.ly/image/1h0z1D32342I

@ghost ghost assigned neumino May 13, 2013
neumino pushed a commit that referenced this issue May 13, 2013
@neumino
Copy link
Member

neumino commented May 13, 2013

So the bug was indeed because we were passing directly false to the handlebars template.
It's fixed in commit aaddc63, branch michel_790_false_values.
Code review 532.

I also found another bug for primitive value in the table view (r.expr(1) wasn't properly displayed).
It's also part of the fix.

@mglukhovsky
Copy link
Member Author

Haha, that makes complete sense (Handlebars + falsey values).

@neumino
Copy link
Member

neumino commented May 14, 2013

Code review done.
Merged in 7764dde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants