Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table name issue system is case-insensitive but tableCreate is case-sensitive #822

Closed
coffeemug opened this issue May 16, 2013 · 10 comments
Closed
Assignees
Milestone

Comments

@coffeemug
Copy link
Contributor

  1. Run r.tableCreate('bar')
  2. Run r.tableCreate('Bar')

The query language happily creates both tables, but the cluster immediately raises an issue that there is a name conflict.

After some discussion with @jdoliner and @mlucy and @srh we decided to fix the issue resolution system to be case-sensitive.

@ghost ghost assigned jdoliner May 16, 2013
jdoliner added a commit that referenced this issue May 20, 2013
@jdoliner
Copy link
Contributor

This is in code review 553. I noticed while testing this that the web UI won't let you create the table "foo" if you already have a table "Foo". We should change that to behavior too just for consistency sake.

@ghost ghost assigned neumino May 20, 2013
@neumino
Copy link
Member

neumino commented May 20, 2013

Reassigning to myself.
I'll update the web ui when I will have a few minutes.

@jdoliner
Copy link
Contributor

K. This is in essence assigned to both of us since I haven't actually committed my part to next yet but whatever we all know what's going on here.

@jdoliner
Copy link
Contributor

My part of this is done. Reviewed by @Tryneus. @neumino make sure to note when this will ship once you complete your part.

@neumino
Copy link
Member

neumino commented May 21, 2013

Just to be sure:
Databases AND tables names are now case sensitive right?

@jdoliner
Copy link
Contributor

Yup.
On May 21, 2013 11:21 AM, "Michel" notifications@github.com wrote:

Just to be sure:
Databases AND tables names are now case sensitive right?


Reply to this email directly or view it on GitHubhttps://github.com//issues/822#issuecomment-18227008
.

@neumino
Copy link
Member

neumino commented May 21, 2013

Done in 52d5343
Code review 559
Branch michel_822_case_sensitive_name

@neumino
Copy link
Member

neumino commented May 23, 2013

Review done.
Merged in next with commit 950b622

@jdoliner is your part merged in next too? If yes, we can close this issue I think.

@jdoliner
Copy link
Contributor

Yup it's in next. I just tried testing the webUI and it still wasn't letting me make tables with names that only differed in capitalization. I tried to do shift + f5 to clear the cache but it still didn't work. I'm betting that something weird is happening here, perhaps with the rebuilding of web assets. Can you confirm that this works in your tests?

@neumino
Copy link
Member

neumino commented May 23, 2013

Err, I'm a moron, I forgot to push on github -_-

I can confirm that it works fine.

@neumino neumino closed this as completed May 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants