Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto completion for opening square bracket #917

Closed
neumino opened this issue May 28, 2013 · 2 comments
Closed

Auto completion for opening square bracket #917

neumino opened this issue May 28, 2013 · 2 comments
Assignees
Milestone

Comments

@neumino
Copy link
Member

neumino commented May 28, 2013

It's currently broken (well, it just doesn't auto complete).

The reason is a little tricky.

I catch the key code 91 because Cmd on OS X maps to it and I want to treat it like a special key (like Alt, Ctrl etc.).
The thing is that the opening bracket also map to the value 91.

I forgot to check for the event.type when I was ignoring Cmd.so I ended up not passing [ to the method pair_char that take care of doing the auto completion.

Fix coming.

@ghost ghost assigned neumino May 28, 2013
@neumino
Copy link
Member Author

neumino commented May 28, 2013

Commit 050a832
Branch michel_917_opening_square_bracket
Code review 563
Ship 1.6 or 1.5.3 if we do another point release.

@neumino
Copy link
Member Author

neumino commented Jun 7, 2013

Review 563 completed.
Merged as 28e075b
Ship 1.6

@neumino neumino closed this as completed Jun 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant