Use os.path.splitext to check file extensions.
#2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I didn't know about |
|
Testing is good when used. I did wonder if |
|
@grandquista that may have been my idea originally. But I don't believe |
|
@AtnNn: what's the state of this pull request? |
|
This patch seems to work great. Thanks! |
AtnNn
added a commit
that referenced
this pull request
Aug 7, 2014
…n_test_name Use `os.path.splitext` to check file extensions.
|
@grandquista This has shipped with 1.14.0, thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File extensions were found by string parsing before. The search for tests and groups was also inconsistent. I have imported the standard library method for finding extensions. Both searches now assume a single directory contains all groups and tests.