Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packaging): speed up debian packaging by parallel builds #5892

Closed
wants to merge 1 commit into from

Conversation

mbroadst
Copy link
Contributor

Description

This speeds up debian packaging by adding j flags to the make steps

@AtnNn
Copy link
Member

AtnNn commented Jun 28, 2016

It would be great if RethinkDB was faster to build and package by default.

However forcing -jnproc`` may break for older versions of make (see #475). Make might also warn that

make[1]: warning: -jN forced in submake: disabling jobserver mode.

An alternative might be to pass -jauto to dpkg-buildpackage in mk/packaging.mk. It would be easier for users who don't or can't build with -j to work around the forced parallelism.

@mbroadst
Copy link
Contributor Author

Ah right! you had mentioned that, I'll check it out

@mbroadst
Copy link
Contributor Author

hmm bummer:

mbroadst@retinoid:/zdata/rethinkdb (speed-up-debian-packaging *$)# dpkg-buildpackage -jauto
dpkg-buildpackage: unknown option or argument -jauto

Use --help for program usage information.
mbroadst@retinoid:/zdata/rethinkdb (speed-up-debian-packaging *$)# cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.4 LTS"

@danielmewes danielmewes added this to the subsequent milestone Jul 5, 2016
@srh
Copy link
Contributor

srh commented Jun 10, 2017

Rebased onto next as of c5868f4. No Debians that we support have that old version of make. Having this would have made my life easier.

@srh srh closed this Jun 10, 2017
@AtnNn AtnNn modified the milestones: 2.5, subsequent Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants