Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap the npm binary to use the correct node.js #6357

Merged
merged 1 commit into from
May 10, 2017
Merged

Wrap the npm binary to use the correct node.js #6357

merged 1 commit into from
May 10, 2017

Conversation

AtnNn
Copy link
Member

@AtnNn AtnNn commented May 10, 2017 •
edited

The npm binary built when fetching node has been broken for a long time.

Fixes #6356

@AtnNn AtnNn added this to the 2.5 milestone May 10, 2017
@AtnNn AtnNn merged commit d64516c into rethinkdb:next May 10, 2017
@AtnNn
Copy link
Member Author

AtnNn commented May 10, 2017

Merging before review to fix the build.

@srh
Copy link
Contributor

srh commented May 10, 2017

Now I'm getting

src/extproc/js_job.cc:4:16: fatal error: v8.h: No such file or directory

@srh srh mentioned this pull request May 10, 2017
Closed
@gabor-boros gabor-boros mentioned this pull request May 8, 2022
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Release 2.5.0
Status: Done
Milestone
2.5.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AtnNn @srh