Shrink size of gc_entry_t #6394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the effect of reducing sizeof(gc_entry_t::block_info_t) by 4 bytes. The value is already stored as a uint16_t in the LBA.
This makes sizeof(block_info_t) == 4 on Windows. The struct layout with heterogeneous types, or perhaps with bools, used 6 bytes otherwise.
|
The most controversial change here is the change of the block size from uint32_t to uint16_t, everywhere. |
|
In next as of ceb207c. Changing block size to uint16_t is not particularly controversial, because we can always change it back later. |
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reduces the memory overhead of gc_entry_t. This reduces the constant factor of memory overhead per unit of data on disk.