OpenSSL-related compilation fixes #6407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I strongly recommend you get this merged because it'll clearly reduce future compatibility pain (which I encountered in Debian Stretch). Writing unit tests for this should be simple enough, and I recommend doing that too. |
Closed
|
This may be a fix for armhf compilation on Debian Jessie as detailed in #6427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some compatibility issues with OpenSSL versions. In a new OpenSSL version, some struct definitions are now removed from header files, their implementation details abstracted away.
I suppose this fix should be backported to v2.3.x and v2.4.x as well as merged into next.
I think that BN_ext_get_uint64 and BN_ext_count_low_zero_bits could use a unit test before this change gets accepted, because I actually have not tested them in any way.