-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace v8 with QuickJS #6978
Replace v8 with QuickJS #6978
Conversation
After a make clean and rebuild, we already see a problem with this PR:
|
I have some time freed up for this. Reviewing the situation, this is the main (or only?) TODO item. |
Well, that and addressing this:
|
I have merged this to v2.4.x. I will make a separate issue for Windows support. The reason I merged without Windows support was that Linux ARM builds were hitting v8 problems in #6999. I still have not tested ARM but that is on the to-do. |
Replaces v8 with QuickJS.
Keeps the Duktape replacement in the git history.
The build system now git clones a vendored repo at https://github.com/srh/rethinkdb-vendored, and we should change that to https://github.com/rethinkdb/rethinkdb-vendored , provided that we do want to make the build system clone a vendored repo for the dependencies this way.
Also, we need to get this working on Windows.