Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace v8 with QuickJS #6978

Merged
merged 17 commits into from
Feb 20, 2022
Merged

Replace v8 with QuickJS #6978

merged 17 commits into from
Feb 20, 2022

Conversation

srh
Copy link
Contributor

@srh srh commented Jun 26, 2021

Replaces v8 with QuickJS.

Keeps the Duktape replacement in the git history.

The build system now git clones a vendored repo at https://github.com/srh/rethinkdb-vendored, and we should change that to https://github.com/rethinkdb/rethinkdb-vendored , provided that we do want to make the build system clone a vendored repo for the dependencies this way.

Also, we need to get this working on Windows.

@srh
Copy link
Contributor Author

srh commented Jun 26, 2021

After a make clean and rebuild, we already see a problem with this PR:

rm: cannot remove './build/vendored/quickjs': No such file or directory
cp: cannot create directory './build/vendored/quickjs': No such file or directory
make[1]: *** [src/build.mk:393: build/vendored/quickjs] Error 1
make[1]: *** Waiting for unfinished jobs....

@srh srh changed the base branch from v2.5.x to v2.4.x July 5, 2021 05:06
@srh
Copy link
Contributor Author

srh commented Feb 20, 2022

Also, we need to get this working on Windows.

I have some time freed up for this. Reviewing the situation, this is the main (or only?) TODO item.

@srh
Copy link
Contributor Author

srh commented Feb 20, 2022

Well, that and addressing this:

VENDORED_REMOTE_REPO := https://github.com/srh/rethinkdb-vendored.git

@srh srh merged commit bfcfbe4 into rethinkdb:v2.4.x Feb 20, 2022
@srh srh deleted the sam/24x/quickjs branch February 20, 2022 01:52
@srh
Copy link
Contributor Author

srh commented Feb 20, 2022

I have merged this to v2.4.x. I will make a separate issue for Windows support.

The reason I merged without Windows support was that Linux ARM builds were hitting v8 problems in #6999.

I still have not tested ARM but that is on the to-do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant