Added basic accuracy and critical hit checks #87

retroandchill · 2024-06-18T22:43:38Z

Pull Request Description
Accuracy and crit checks were added.

Reviewer Checklist

Is the code easy to read an follow
Is it annotated with the proper header comment blocks
Do all fields and methods contain the proper documentation comments above them
Do any Unreal accessible fields and methods make sense to be so
Are there any potential security or performance issues from the implementation?
Is the new code covered by unit tests?
Are there any new issues in SonarCloud that need to be addressed before merging the code in?

sonarcloud · 2024-06-21T02:07:37Z

Quality Gate failed

Failed conditions
68.3% Coverage on New Code (required ≥ 80%)

retroandchill added 20 commits June 16, 2024 18:19

Added the basic check information for a move

e410a2d

Added the basic layout of the critical calculations

b1b4264

Added some basic critical hit rate modification traits

33a2664

Changed trait utilities to use some template code

db39134

Updated the update code to use a more generic template approach

6f7aac8

Fixed MSVC build issues

74ea3c8

Made the definition hack a windows only convention

def9f8d

Added a new trait to override the crit rate

c299be9

Updated the damage calc test

54fdd3a

Fixed the compiler setup

939a90a

Restored old member accessor fix

ff4f411

Fixed lone test failure

e462952

Began transition over to GoogleMock instead of FakeIt

b02de5f

Additional code changeover

7c392b4

Removed all references to FakeIt from the code

769b5f3

Removed RTTI from a bunch of places

6d8cf0d

Removed most instances of member_accessor

3f5d621

Fixed all test issues from the mocking and private access refactor

30909e8

Added a test for the standard critical hit roll

5bc1f7b

Added additional tests to increase coverage

32f7f15

retroandchill merged commit cfa1361 into main Jun 21, 2024
1 of 2 checks passed

retroandchill deleted the feature/accuracy-and-crit-checks branch June 21, 2024 02:10