-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI-6623 -Yrepl-use-magic-imports avoids nesting $iw wrappers #79
Commits on Oct 31, 2019
-
[nomerge] Avoid allocations of reusable CanBuildFroms
(For 2.12.x's eyes only.) Use vals to cache a single instance of stateless CanBuildFrom instances. These are cast by the existing `implicit def` to the suitable generic type. This pattern was already used in some places -- this PR applies it systematically across `collection.{mutable,immutable}`. The `CanBuildFrom` instances for arrays and wrapped arrays are cached for each primitive type, Unit, and Object. Each of these instances is backed by a dedicated subclass of CanBuildFrom that avoids subsequent dispatch on the `ClassTag[T]`.
Configuration menu - View commit details
-
Copy full SHA for b6ba518 - Browse repository at this point
Copy the full SHA b6ba518View commit details -
Configuration menu - View commit details
-
Copy full SHA for f986e03 - Browse repository at this point
Copy the full SHA f986e03View commit details
Commits on Nov 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 999239c - Browse repository at this point
Copy the full SHA 999239cView commit details
Commits on Nov 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4109888 - Browse repository at this point
Copy the full SHA 4109888View commit details -
Merge pull request scala#8560 from som-snytt/backport/t11802
[nomerge] Backport windows test fix
Configuration menu - View commit details
-
Copy full SHA for e2ca633 - Browse repository at this point
Copy the full SHA e2ca633View commit details
Commits on Dec 1, 2019
-
order matches in expected frequency order (Array, WrappedArray + associated builders, and ClassTag.newArray) avoid extra def in BitSets don't optimise for NoBuilder cases
Configuration menu - View commit details
-
Copy full SHA for 18bf349 - Browse repository at this point
Copy the full SHA 18bf349View commit details
Commits on Dec 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 10b635e - Browse repository at this point
Copy the full SHA 10b635eView commit details -
Merge pull request scala#8569 from hrhino/topic/more-tests
two more tests for apparently-fixed issues
Configuration menu - View commit details
-
Copy full SHA for f0c3dbc - Browse repository at this point
Copy the full SHA f0c3dbcView commit details -
Merge pull request scala#8550 from som-snytt/issue/11807-2.12
[nomerge] ConcatIterator.last advances
Configuration menu - View commit details
-
Copy full SHA for de94b78 - Browse repository at this point
Copy the full SHA de94b78View commit details
Commits on Dec 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b21589b - Browse repository at this point
Copy the full SHA b21589bView commit details -
Merge pull request scala#8572 from lrytz/travis-import-2.12
[backport] Import travis caching config and JDK install from scala-dev
Configuration menu - View commit details
-
Copy full SHA for fc6d511 - Browse repository at this point
Copy the full SHA fc6d511View commit details
Commits on Dec 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f9d9136 - Browse repository at this point
Copy the full SHA f9d9136View commit details -
Merge pull request scala#8467 from rorygraves/mike/2.12_CanBuildFrom
Avoid allocations of reusable CanBuildFroms
Configuration menu - View commit details
-
Copy full SHA for de3451d - Browse repository at this point
Copy the full SHA de3451dView commit details
Commits on Dec 10, 2019
-
The test allocates 16*16 MB, so testing with a 192 MB heap should be safe to catch the leak. Tested with running the test in a `while true` loop locally - constanly fails with 192 MB on 2.13.1 - constantly succeeds with 192 MB on 2.13.2-bin-9ef8fc3 - flaky with 128 MB on 2.13.2-bin-9ef8fc3 (cherry picked from commit ffcffc6)
Configuration menu - View commit details
-
Copy full SHA for 36c6888 - Browse repository at this point
Copy the full SHA 36c6888View commit details -
Merge pull request scala#8585 from retronym/topic/backport-type-tag-leak
[backport] Bump Xmx for type-tag-leak
Configuration menu - View commit details
-
Copy full SHA for e474144 - Browse repository at this point
Copy the full SHA e474144View commit details -
- Make `ImportContext` a nested class - Avoid the constructor of the superclass `Context` needing to call methods on the unitialized subclass ImportContext by computing `isRootContext` / `depth` externally in the factory method.
Configuration menu - View commit details
-
Copy full SHA for dca6f5a - Browse repository at this point
Copy the full SHA dca6f5aView commit details -
SI-6623 -Yrepl-use-magic-imports avoids nesting $iw wrappers
Rather than adding a wrapper object for each import in the session history, just use a single wrapper preceded by the imports which have been interspersed with a magic import to bump context depth. Code is still ordinarily wrapped in a `$read` object. This is a step toward 6623-like transparency. `retronym` takes the blame for this innovation. `adriaanm` collaborated in its commission. `somsnytt` batted clean-up.
Configuration menu - View commit details
-
Copy full SHA for 317775b - Browse repository at this point
Copy the full SHA 317775bView commit details -
Enable magic imports unconditionally to survey test results
To be reverted.
Configuration menu - View commit details
-
Copy full SHA for 9e146e8 - Browse repository at this point
Copy the full SHA 9e146e8View commit details -
Run some completions tests under -Yrepl-classbased and fix completion…
… bug By default, the parser tries to heal incomplete source files by inserting missing braces. Compilation will still error out, but any subsequent parser/type errors make more sense to the user when this healing works. The healing uses indentation to figure out the intent of the code. Wrapped REPL snippets aren't properly indented, and in the test case I added the healing seems counterproductive. This commit disables it in REPL tab completion, in line with the way that IMain parses the wrapped code for real compilation.
Configuration menu - View commit details
-
Copy full SHA for 7613d84 - Browse repository at this point
Copy the full SHA 7613d84View commit details -
Small improvements to REPL -Yrepl-class-based
- add comments describing a problem I discovered with imports and a possible solution - Make strip wrappers from REPL output for the wrappers generated in this mode
Configuration menu - View commit details
-
Copy full SHA for 1659fec - Browse repository at this point
Copy the full SHA 1659fecView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff991f5 - Browse repository at this point
Copy the full SHA ff991f5View commit details
Commits on Dec 12, 2019
-
Stabilize output in REPL tests between indy and inline lambdas
This detail changes under -Yrepl-class-based. We prefer tests that operate under either mode.
Configuration menu - View commit details
-
Copy full SHA for f4cb764 - Browse repository at this point
Copy the full SHA f4cb764View commit details -
Configuration menu - View commit details
-
Copy full SHA for cba5394 - Browse repository at this point
Copy the full SHA cba5394View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50c74cd - Browse repository at this point
Copy the full SHA 50c74cdView commit details