Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVT Play no listing #1718

Closed
1 of 7 tasks
dobbelina opened this issue Sep 4, 2023 · 26 comments
Closed
1 of 7 tasks

SVT Play no listing #1718

dobbelina opened this issue Sep 4, 2023 · 26 comments
Assignees
Labels
bug Something isn't working

Comments

@dobbelina
Copy link

Bug report

Since this morning SVT Play no listing regardless of link used, debug log made.

Describe the bug

Expected Behavior

Actual Behavior

Possible Fix

To Reproduce

Steps to reproduce the behavior:

Debuglog

https://paste.kodi.tv/koramaqaqi.kodi

The debug retrospect.log can be found here:

Screenshots

Additional context or screenshots (if appropriate)

Your Environment

Used Operating system:

  • Android
  • iOS
  • Linux
  • OSX
  • Raspberry-Pi
  • Windows
  • Windows UWP

Used versions:

  • Kodi version: 20.2
  • Retrospect version: 5.6.4
@dobbelina dobbelina added the bug Something isn't working label Sep 4, 2023
@basrieter basrieter self-assigned this Sep 4, 2023
@create-issue-branch
Copy link

Branch bug-1718 was created for issue: "SVT Play no listing"

@basrieter
Copy link
Collaborator

The api was updated.

@basrieter
Copy link
Collaborator

Please try this version via the "install from zip" option:

https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip

Most stuff should be working, except tags/genres and perhaps the search.

@dobbelina
Copy link
Author

@basrieter
Fix works, thank you.

@matsarv
Copy link
Contributor

matsarv commented Sep 5, 2023

In the initial fix I found a few things that didn't work:

  • Categories

  • Genres\tags (mentioned above)

  • Live TV (This is working in version 5.6.4)

  • Öppet arkiv

  • Search (mentioned above)

  • 'Currently playing' needs the time before title so we don't trying to play a program in the future. Right now there is 13 'Rapport' in the list. I think it used to be like this: '18:00 - Rapport'

@basrieter
Copy link
Collaborator

In the initial fix I found a few things that didn't work:

  • Categories
  • Genres\tags (mentioned above)
  • Live TV (This is working in version 5.6.4)
  • Öppet arkiv
  • Search (mentioned above)
  • 'Currently playing' needs the time before title so we don't trying to play a program in the future. Right now there is 13 'Rapport' in the list. I think it used to be like this: '18:00 - Rapport'

Those are more or less the ones I mentioned in my post.

@basrieter
Copy link
Collaborator

Please try https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip again. I think it is all working again: 2 notes:

  1. The "All Genres/Tags" was removed from their API (can't find it) so the listing is not as long as it was.
  2. The "Currently playing" thing with the time won't work with the time in front, as it might also be that time day after.

Only thing left is the "Live streams".

@basrieter
Copy link
Collaborator

Live streams fixed: https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip

Please verify, as I can't really from the Netherlands.

@matsarv
Copy link
Contributor

matsarv commented Sep 11, 2023

I have tested all first level folders and some Categories folders and eveything is working.


I have found a couple of things that could be enhanced.
I think Categories is rather important for the look and feel.


Categories

If you goto Categories and select Drama,
all Singels and TVSeries are missing the image and fanart.

categories-images

On the next level in TVSeries the image and fanart are shown for the folders (Klipp, Sasong x and Upptäck mer)

categories-images2

The info for this seems to be extracted from the API.
I guess this could also be applied for Genres/tags

Single:

20230911 11:46:55 - [TRACE   ] - chn_svt.py           - 418  - Single: {'id': '1403983-001', 'name': 'At the Window', '__typename': 'Single', 'urls': {'svtplay': '/video/KZm7rmd/at-the-window', '__typename': 'Urls'}, 'oppetArkiv': False, 'restrictions': {'onlyAvailableInSweden': False, 'onlyAvailableInSwedenFormatted': 'Kan ses i hela världen', '__typename': 'Restrictions'}, 'svtId': 'KZm7rmd', 'videoSvtId': 'jpAdZzp', 'images': {'cleanWide': {'changed': 1686741501, 'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'id': '50073851', 'keyart': False, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'changed': 1686741501, 'id': '50073855', 'keyart': False, '__typename': 'Image'}, '__typename': 'Images'}, 'parent': {'id': '1403983-001', 'name': 'At the Window', 'svtId': 'KZm7rmd', 'images': {'wide': {'changed': 1686741500, 'id': '50073843', 'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', '__typename': 'Image'}, 'cleanWide': {'changed': 1686741501, 'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'id': '50073851', 'keyart': False, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'At the Window - En flicka står vid fönstret och blickar ut över den snötäckta trädgården utanför. Bakom henne ligger hennes sjuka mamma i sin säng. När en otäck varelse dyker upp i trädgården suddas gränsen mellan dröm och verklighet ut.', 'changed': 1686741501, 'id': '50073855', 'keyart': False, '__typename': 'Image'}, '__typename': 'Images'}, 'urls': {'svtplay': '/video/KZm7rmd/at-the-window', '__typename': 'Urls'}, '__typename': 'Single'}, 'validFrom': '2023-06-30T02:00:00+02:00', 'validFromFormatted': 'Fre 30 jun 02:00', 'duration': 461, 'variants': [{'accessibility': 'Default', 'urls': {'svtplay': '/video/jpAdZzp/at-the-window', '__typename': 'Urls'}, '__typename': 'Variant'}], 'accessibilities': []}

TVSeries:

20230911 11:46:55 - [TRACE   ] - chn_svt.py           - 418  - TvSeries: {'id': 'eopv56n', 'name': 'Atlantic crossing', '__typename': 'TvSeries', 'urls': {'svtplay': '/atlantic-crossing', '__typename': 'Urls'}, 'oppetArkiv': False, 'restrictions': {'onlyAvailableInSweden': True, 'onlyAvailableInSwedenFormatted': 'Kan bara ses i Sverige', '__typename': 'Restrictions'}, 'svtId': 'eopv56n', 'videoSvtId': 'jnDJZE6', 'images': {'cleanWide': {'changed': 1686136164, 'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'id': '29701314', 'keyart': True, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'changed': 1686136159, 'id': '29756634', 'keyart': True, '__typename': 'Image'}, '__typename': 'Images'}, 'parent': {'id': 'eopv56n', 'name': 'Atlantic crossing', 'svtId': 'eopv56n', 'images': {'wide': {'changed': 1686136164, 'id': '29701314', 'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', '__typename': 'Image'}, 'cleanWide': {'changed': 1686136164, 'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'id': '29701314', 'keyart': True, '__typename': 'Image'}, 'logotype': None, 'cleanPortrait': {'description': 'Kronprins Olav (Tobias Santelmann), kronprinsesse Märtha (Siofia Helin) och president Franklin D. Roosevelt. - Atlantic crossing', 'changed': 1686136159, 'id': '29756634', 'keyart': True, '__typename': 'Image'}, '__typename': 'Images'}, 'urls': {'svtplay': '/atlantic-crossing', '__typename': 'Urls'}, '__typename': 'TvSeries'}, 'accessibilities': []}

Currently playing

Currently playing looks like this

CurrPlay1

In the def create_api_teaser_type(self, result_set):
remark the following:

Row 579

from:
            if self.parentItem.metaData.get(self.__filter_subheading, True) and (
                    "Idag" in sub_heading
                    or "Ikväll" in sub_heading
                    or "Igår" in sub_heading
                    or sub_heading.endswith(" sek")
                    or sub_heading.endswith(" min")
                    or sub_heading.endswith(" tim")):
                Logger.trace("Ignoring subheading: %s", sub_heading)
                new_result_set["name"] = title
to:
            # if self.parentItem.metaData.get(self.__filter_subheading, True) and (
                    # "Idag" in sub_heading
                    # or "Ikväll" in sub_heading
                    # or "Igår" in sub_heading
                    # or sub_heading.endswith(" sek")
                    # or sub_heading.endswith(" min")
                    # or sub_heading.endswith(" tim")):
                # Logger.trace("Ignoring subheading: %s", sub_heading)
                # new_result_set["name"] = title

Now Currently playing looks like this, with info when the show is available.

Currplay2

Live TV

Live TV looks like this

LiveTV1

Live TV in version 5.6.4 still works and it looks like this.

LiveTV2

In the above all images is fetched from the API even when no show is playing.

Maybe you could add the end time to the latest working and it is fixed.


All is working and this is just enhancement if you got the time.
Greate work! Thanks for all the hard work fixing this to us.

@basrieter
Copy link
Collaborator

Thanks for your feedback:

  • Currently Playing: Fixed (forgot something)
  • Live TV: End times are no longer present in the API. But I managed to get one by reading the next item in the list.
  • Live TV: Thumbs are not always present. But most have them.

I will have a look at the artwork in general.

@basrieter
Copy link
Collaborator

Please redownload https://github.com/retrospect-addon/plugin.video.retrospect/archive/refs/heads/bug-1718.zip and see if it is better now?

@matsarv
Copy link
Contributor

matsarv commented Sep 11, 2023

This is the image from Categories and Drama using Viewtype: Wall

Drama_1

The poster images only seems to work on Movies,
As for Series, text don't fit, text is missing, so you don't allways see the name.

Drama2

Before you used the format image and there was the name of the shows allways visible.
I guess the image used in TVSeries show folder is the best option.

My guess is that the posters are not ready to use everyware yet.

@matsarv
Copy link
Contributor

matsarv commented Sep 11, 2023

Currently Playing and Live TV look perfect and is workig OK

@basrieter
Copy link
Collaborator

The thumbs/poster are generated using their own API and the JSON data they send. They apparently cut of text:

https://www.svtstatic.se/image/portrait/1080/36820195/1686132923

@matsarv
Copy link
Contributor

matsarv commented Sep 11, 2023

@basrieter
Copy link
Collaborator

For the thumbs: use image/custom instead of image/portrait

https://www.svtstatic.se/image/custom/430/36820195/1686132923 https://www.svtstatic.se/image/custom/720/36820195/1686132923 https://www.svtstatic.se/image/custom/1080/36820195/1686132923

But then they won't be "portrait" format and Kodi will "squeeze" them:
image

@basrieter
Copy link
Collaborator

This is what a poster should be:

image

@matsarv
Copy link
Contributor

matsarv commented Sep 12, 2023

Posters (portraits) in previously Retrospect were never used in SVT Play.
Now Posters are used everywhere with the fix and it shows croped images, part of the text on images and images without text. It's not ready for using Poster everywhere.

When listing all the Category / Series on the website it uses the custom image
https://www.svtplay.se/kategori/serier?tab=all

When listing the TVshow, the foldes 'Säsong', 'Klipp' and 'Upptäck' mer uses the custom image
https://www.svtplay.se/atlantic-crossing

After the [Fixed: SVT artwork.] was applied it seems that everything changed from 'Thumbs = Images' to 'Thumbs = Posters' everywhere.

I think you should remove the fix and get back to use 'Thumbs = Images' for everything as before and just fix 'Thumbs = Images' for Categories and Genre/tags.

@matsarv
Copy link
Contributor

matsarv commented Sep 12, 2023

I have gone back and dowloaded the version up to the fix:
Changed: SVT Live and Currently Playing tweaks.

I have tested this version and everything is working as before the API changes.
It looks perfect except for one thing as mentioned.

  • Open 'Categories' and goto 'Drama'.

Categories

  • See the images used for the folder 'Drama'
  • Open 'Drama' folder

CategoriesDrama

Both Singles items and TVSeries Folders is using the parent info from 'Drama'.
The foldes below this is working OK.

CategoriesDramaAtlantic

The only thing needs to be fixed is that Singels and TVSeries should be using Singles items image and TVSeries Folders image and not use the parent 'Drama' images,

If not possibe to fix this I think this is far better to released this and not the changes with using Posters.

@basrieter
Copy link
Collaborator

So basically: no posters, just thumbs?

@basrieter
Copy link
Collaborator

@matsarv
Copy link
Contributor

matsarv commented Sep 12, 2023

Great work. Everyting looks fanatastic with the images now!

I did find that the Search gives an error.
Retrospect-log: https://paste.kodi.tv/dolafipero.kodi

@basrieter
Copy link
Collaborator

Great work. Everyting looks fanatastic with the images now!

I did find that the Search gives an error. Retrospect-log: https://paste.kodi.tv/dolafipero.kodi

What did you search for?

@matsarv
Copy link
Contributor

matsarv commented Sep 12, 2023

chn_class.py - 502 - Searching for 'abba'

I did a search on 'Lokala' and that works.

@matsarv
Copy link
Contributor

matsarv commented Sep 12, 2023

I guess it has to do with 'onlyAvailableInSweden'

See the above log:
folderaction.py - 133 - + KeyError: 'restrictions'

@dobbelina
Copy link
Author

When i click "Recent" the description is missing, seems it's using the heading instead?
See 3 screenshots below that illustrates what i mean:
image
And
image
And
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants