[eclipse-wakaamaGH-182] ci: Run Clang Static Analyzer

Findings are available as artifact, but no further actions (e.g.
breaking the build) taken. Will gladdy do so however once we have fixed
the current findings.

Signed-off-by: Reto Schneider <code@reto-schneider.ch>

.github/workflows/clang-static-analyzer.yaml

@@ -0,0 +1,32 @@
+name: Clang Static Analyzer
+
+on: [push, pull_request]
+
+jobs:
+  clang_static_analyzer:
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Checkout code including full history and submodules
+      uses: actions/checkout@v2
+      with:
+        submodules: true
+        fetch-depth: 0
+
+    - name: Install dependencies from APT repository
+      run: sudo apt-get install clang-tools-10 libcunit1-dev wget unzip
+
+    - name: Install CMake
+      uses: lukka/get-cmake@latest
+
+    - name: Install Ninja
+      uses: seanmiddleditch/gha-setup-ninja@master
+
+    - name: Run Clang Static Analyzer
+      run: tools/ci/run_ci.sh --build --scan-build scan-build-10
+
+    - name: Upload scan build reports
+      uses: actions/upload-artifact@v1
+      with:
+        name: Clang Static Analyzer Reports
+        path: build-wakaama/clang-static-analyzer

tools/ci/run_ci.sh

@@ -26,6 +26,8 @@ RUN_TESTS=0
 OPT_VERBOSE=0
 OPT_SANITIZER=""
 OPT_TEST_COVERAGE_FORMAT=""
+OPT_SCAN_BUILD=""
+OPT_WRAPPER_CMD=""
 
 HELP_MSG="usage: ${SCRIPT_NAME} <OPTIONS>...
 Runs build and test steps in CI.
@@ -37,6 +39,9 @@ Options:
  -h, --help                Display this help and exit
  --sanitizer TYPE          Enable sanitizer
                            (TYPE: address leak thread undefined)
+ --scan-build BINARY       Enable Clang code analyzer using specified
+                           executable
+                           (BINARY: e.g. scan-build-10)
  --test-coverage FORMAT    Create coverage info in given FORMAT
                            (FORMAT: xml html text)
 
@@ -60,8 +65,8 @@ function run_clean() {
 function run_build() {
   mkdir build-wakaama
   pushd build-wakaama
-  cmake -GNinja -S .. ${CMAKE_ARGS}
-  ninja
+  ${OPT_WRAPPER_CMD} cmake -GNinja -S .. ${CMAKE_ARGS}
+  ${OPT_WRAPPER_CMD} ninja
   popd
 }
 
@@ -118,6 +123,7 @@ if ! PARSED_OPTS=$(getopt -o vah \
                           -l clean \
                           -l help \
                           -l sanitizer: \
+                          -l scan-build: \
                           -l run-tests \
                           -l test-coverage: \
                           -l verbose \
@@ -146,6 +152,11 @@ while true; do
       OPT_SANITIZER=$2
       shift 2
       ;;
+    --scan-build)
+      OPT_SCAN_BUILD=$2
+      RUN_CLEAN=1 # Analyzing works only when code gets actually built
+      shift 2
+      ;;
     --test-coverage)
       OPT_TEST_COVERAGE_FORMAT=$2
       shift 2
@@ -191,6 +202,11 @@ if [ -n "${OPT_TEST_COVERAGE_FORMAT}" ]; then
   CMAKE_ARGS="${CMAKE_ARGS} -DCOVERAGE=ON"
 fi
 
+if [ -n "${OPT_SCAN_BUILD}" ]; then
+  OPT_WRAPPER_CMD="${OPT_SCAN_BUILD} \
+    -o clang-static-analyzer"
+fi
+
 # Run Steps
 
 if [ "${RUN_CLEAN}" -eq 1 ]; then