-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not remove findings with same range but different metavariables #3310
Conversation
This closes #3279 test plan: test file included and semgrep --config ~/yy/tests/OTHER/rules/misc_field.yaml ~/yy/tests/OTHER/rules/misc_field.js returns now 22 findings (same range though).
|
Relevant slack conversation: |
Potential non-blocking slowdown latest time 3.996 is over 12 percent slower than baseline 3.519. See run output for more details |
We got a big release, so This is potentially a big change so I wait for the release cut to merge this. |
This pull request is being marked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any test that has 22 extra findings @aryx, am I missing something?
This works now on develop: https://semgrep.dev/s/2b25?version=develop |
This closes #3279
test plan:
test file included
and
semgrep --config ~/yy/tests/OTHER/rules/misc_field.yaml
~/yy/tests/OTHER/rules/misc_field.js
returns now 22 findings (same range though).
PR checklist: