Declaration ellipsis #3720
Merged
Declaration ellipsis #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still a draft or can I merge? |
|
This still needs a release of semgrep-c-sharp, and then the submodule in this PR needs to point to the released version of semgrep-c-sharp. |
Related to semgrep#3702
C#: support ellipsis in declarations (semgrep#3720)
Sjord
force-pushed
the
declaration-ellipsis
branch
from
a0abbaa
to
79e7393
Compare
|
This is ready for review and merge. |
|
@aryx Could you have another look at this? |
aryx
approved these changes
Aug 25, 2021
Sjord
commented
Aug 26, 2021
| @@ -19,6 +19,7 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html | |||
| - Add help text to sarif formatter output if defined in metadata field. | |||
| - Update shortDescription in sarif formatter output if defined in metadata field. | |||
| - Add tags as defined in metadata field in addition to the existing tags. | |||
| - C#: support ellipsis in declarations (#3720) | |||
There was a problem hiding this comment.
This is in the wrong place. I put this under 0.62.0, but it should have gone under Unreleased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
class A { ... }in C#.Requires semgrep/ocaml-tree-sitter-semgrep#247
Closes #3702