target_manager: add verbose log on git failure #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging a slow-running semgrep usage, I discovered that files included in the `.gitignore` were being scanned because `git` was not available in the container running the scan (note: not the official semgrep container). Add a log message when this occurs to help others debug this in the future.
|
|
brendongo
approved these changes
Aug 30, 2021
brendongo
changed the title
brendongo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a slow-running semgrep usage, I discovered that files
included in the
.gitignorewere being scanned becausegitwas notavailable in the container running the scan (note: not the official
semgrep container).
Add a log message when this occurs to help others debug this in the
future.
PR checklist: