Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename and split Match_search_rules.ml in many files #5500

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

aryx
Copy link
Collaborator

@aryx aryx commented Jun 13, 2022

This file was getting big

test plan:
make

PR checklist:

  • Documentation is up-to-date
  • Changelog is up-to-date
  • Change has no security implications (otherwise, ping security team)

This file was getting big

test plan:
make
@aryx aryx requested a review from a team June 13, 2022 12:51
@linear
Copy link

linear bot commented Jun 13, 2022

PA-1448 metavariable-pattern not flagging with PHP code

Describe the bug
Metavariable-pattern is flagging PHP code with 'generic' mode, but not with 'php' mode.

To Reproduce
For instance, this doesn't flag: https://semgrep.dev/s/WRD2

But this does: https://semgrep.dev/s/02Wj

Expected behavior
Would expect it to flag with php as the language.

Priority
How important is this to you?

  • P0: blocking me from making progress
  • P1: this will block me in the near future
  • P2: annoying but not blocking me

From #5443
Originally opened by colleend

@aryx aryx merged commit 6f42a4e into develop Jun 13, 2022
@aryx aryx deleted the pad/pa-1448-metavariable-pattern-not-flagging-with branch June 13, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant