Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdownify.html should not return result via scratch #137

Closed
palant opened this issue May 12, 2020 · 1 comment · Fixed by #153
Closed

markdownify.html should not return result via scratch #137

palant opened this issue May 12, 2020 · 1 comment · Fixed by #153
Labels
enhancement New feature or request
Milestone

Comments

@palant
Copy link
Collaborator

palant commented May 12, 2020

It's rather awkward and inconvenient that markdownify.html puts its result in .Scratch, it should use return instead.

@reuixiy
Copy link
Owner

reuixiy commented May 12, 2020

Agreed.

@reuixiy reuixiy added the enhancement New feature or request label May 12, 2020
@reuixiy reuixiy added this to the v4.4.0 milestone May 12, 2020
palant added a commit that referenced this issue May 17, 2020
...instead of abusing .Scratch

Fixes #137

* Make markdownify.html and content.html return results properly

* Make author.html return results properly

* Make auto-detect-images.html and images.html return results properly

* Make date.html return results properly

* Make data-attributes.html return result properly

* Make title.html return results properly

* Make toc.html return results properly

* Make relative-url.html return results properly

* Make tree-sections.html return results properly (untested)

* Rolled back change to tree-sections.html, doesn't work

BREAKING CHANGE: Various templates under `utils/partials/` will return results directly rather than via `.Scratch` now.
ulmefors pushed a commit to ulmefors/hugo-theme-meme that referenced this issue Nov 22, 2020
...instead of abusing .Scratch

Fixes reuixiy#137

* Make markdownify.html and content.html return results properly

* Make author.html return results properly

* Make auto-detect-images.html and images.html return results properly

* Make date.html return results properly

* Make data-attributes.html return result properly

* Make title.html return results properly

* Make toc.html return results properly

* Make relative-url.html return results properly

* Make tree-sections.html return results properly (untested)

* Rolled back change to tree-sections.html, doesn't work

BREAKING CHANGE: Various templates under `utils/partials/` will return results directly rather than via `.Scratch` now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants