Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultTheme 預設是 dark 的情況下，切回 light 時，圖片的對比不會變回100%。 #365

Closed
starspiritstorm opened this issue Jan 17, 2022 · 2 comments
Closed

defaultTheme 預設是 dark 的情況下，切回 light 時，圖片的對比不會變回100%。 #365

starspiritstorm opened this issue Jan 17, 2022 · 2 comments

Comments

@starspiritstorm
Copy link
Contributor

reuixiy 你好，

我發現了一個問題，
defaultTheme 預設是 dark 的情況下，切回 light 時，圖片的對比不會變回100%。

最後我找到在
https://github.com/reuixiy/hugo-theme-meme/blob/master/assets/scss/themes/_light.scss
這裡面也需要加上

img {
    filter: brightness(100%);
}

image

才會正常切換，此項修正需要 pull request 還是請你自行更新呢？
@reuixiy
Copy link
Owner

reuixiy commented Jan 17, 2022

PR welcome!

starspiritstorm pushed a commit to starspiritstorm/hugo-theme-meme that referenced this issue Jan 17, 2022
fix(scss): solve when defaultTheme is dark, images won't change to 10…
c54362a 
…0% contrast when toggled to light mode (reuixiy#365)
@starspiritstorm starspiritstorm mentioned this issue Jan 17, 2022
Closed
starspiritstorm added a commit to starspiritstorm/hugo-theme-meme that referenced this issue Jan 17, 2022
@starspiritstorm
fix(scss): solve when defaultTheme is dark, images won't change to 10…
6f2487d 
…0% contrast when toggled to light mode (reuixiy#365)
@starspiritstorm starspiritstorm mentioned this issue Jan 17, 2022
Merged
@starspiritstorm
Copy link
Contributor Author

不好意思剛剛用錯帳號commit了，請用#367的PR。

ulmefors pushed a commit to ulmefors/hugo-theme-meme that referenced this issue Jan 22, 2024
@starspiritstorm @ulmefors
fix(css): dim image in light mode (reuixiy#367)
19844ff 
When defaultTheme is dark, images brightness didn't change to 100% in light mode.

FIxed reuixiy#365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@starspiritstorm @reuixiy