Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numbers to represent number of changes #4

Closed
iilyak opened this issue Jan 2, 2019 · 3 comments
Closed

Use numbers to represent number of changes #4

iilyak opened this issue Jan 2, 2019 · 3 comments

Comments

@iilyak
Copy link

iilyak commented Jan 2, 2019

This is mostly a feature request not really a bug. IMO it would be better to use integers to represent number of changes from upstream. I work with codebases which can diverge significantly from upstream. Currently number of stashed changes is represented by n stash icons. Where n is number of changes ( stashes += &icons::get("stash");). Same goes for ahead and behind

graph = icons::get("ahead").repeat(ahead)
+ &icons::get("behind").repeat(behind);

The problem with this approach is that it takes the screen space. It makes prompt taking few lines for some edge cases. It could be changed to show this info in colored sections like follows:

------\-----------------\----------------\------------------\
       > :stash_icon: 5  > :ahead_icon: 8 > :behind_icon: 10 >
------/-----------------/----------------/------------------/
@iilyak
Copy link
Author

iilyak commented Jan 2, 2019

The cosmetics which could be used are:

  • nf-mdi-numeric_9_plus_box_multiple_outline if having 9+ instead of exact number is acceptable
  • :nf-pl-left_hard_divider: :stash: 5 :nf-ple-flame_thick: :ahead: 8 :nf-ple-flame_thick: :behind: 10 :nf-pl-left_hard_divider:
  • :nf-pl-left_hard_divider: :stash: 5 :nf-pl-left_soft_divider: :ahead: 8 :nf-pl-left_soft_divider: :behind: 10 :nf-pl-left_hard_divider:

@reujab reujab closed this as completed in 85ad063 Jan 2, 2019
@reujab
Copy link
Owner

reujab commented Jan 2, 2019

I just released v1.0.4, which fixed this issue. No more than five icons should be displayed at a time.

@iilyak
Copy link
Author

iilyak commented Jan 3, 2019

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants