Update to foobar2000 SDK 2022-01-04 and use vcpkg manifest mode #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reupen
force-pushed
the
SDK-2022-01-04
branch
3 times, most recently
from
c750743
to
67f083d
Compare
This updates submodules to bring in changes from foobar2000 SDK 2022-01-04. Some bits of code were tidied up as part of this and `fmt` was added as a dependency (`std::format()` isn't used as it's not currently available in VS 2022 with the /std:c++20 compiler option). Finally, vcpkg is now used in manifest mode to simplify handling of dependencies. Currently, only a single manifest in the root directory is used rather than having manifests for each project (I'm not sure how exactly the latter would behave, particularly if the manifests conflicted with each other).
reupen
force-pushed
the
SDK-2022-01-04
branch
from
67f083d
to
51af6b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates submodules to bring in changes from foobar2000 SDK 2022-01-04.
Some bits of code were tidied up as part of this and
fmtwas added as a dependency (std::format()isn't used as it's not currently available in VS 2022 with the /std:c++20 compiler option).Finally, vcpkg is now used in manifest mode to simplify handling of dependencies. Currently, only a single manifest in the root directory is used rather than having manifests for each project (I'm not sure how exactly the latter would behave, particularly if the manifests conflicted with each other).