Hebrew error with polyglossia 1.47 and lualatex

[gildasius]

When I use Hebrew with polyglossia 1.47 and LuaLaTeX on TeXLive 2019, I get an error message that I don't get with polyglossia 1.46. I got some answers from tex.stack.exchange, but I thought I would also report it here as a possible bug. Here is my MWE:

%!TEX TS-program = lualatex
%!TEX encoding = UTF-8 Unicode

\documentclass{article}
\usepackage{fontspec}
\newfontfamily\hebrewfont{SBL Hebrew}[Script=Hebrew]
\usepackage{polyglossia}
\setdefaultlanguage[variant=us]{english}
\setotherlanguage{hebrew}

\begin{document}
Text in English and \texthebrew{עברית}. Text...
\end{document}

The messages I get

Package polyglossia Warning: Hebrew is not supported with LuaTeX.
(polyglossia) I will proceed with the compilation, but
(polyglossia) the output is not guaranteed to be correct
(polyglossia) and may look very wrong. on input line 6.

(/usr/local/texlive/2019/texmf-dist/tex/lualatex/luabidi/luabidi.sty
(/usr/local/texlive/2019/texmf-dist/tex/lualatex/luabidi/luabidi-footnotes.def)
) (/usr/local/texlive/2019/texmf-dist/tex/latex/polyglossia/hebrewcal.sty
(/usr/local/texlive/2019/texmf-dist/tex/latex/polyglossia/cal-util.def))
Setting \if@calendar@hebrew
(/usr/local/texlive/2019/texmf-dist/tex/latex/polyglossia/babel-hebrewalph.def)

! Too many }'s.
l.120 \fi}
%
! Extra \fi.
l.121 \fi

[moewew]

I can't say I have understood \if... matching, but if I replace

polyglossia/tex/gloss-hebrew.ldf

Lines 117 to 119 in 6239583

	\ifxetex
	\newcommand\xpg@hebrew@DigitsDotDashInterCharToks{\if@nonlatin\char"200E \fi}
	\fi

with

\ifxetex
  \expandafter\@firstoftwo
\else
  \expandafter\@secondoftwo
\fi
  {\newcommand\xpg@hebrew@DigitsDotDashInterCharToks{\if@nonlatin\char"200E \fi}}
  {}

things appear to work again.

---

I think there might be spurious spaces from

polyglossia/tex/gloss-hebrew.ldf

Line 123 in 6239583

\XeTeXinterchartoks \bidi@sepmark@charclass \bidi@digits@charclass = {\xpg@hebrew@DigitsDotDashInterCharToks}

and

polyglossia/tex/gloss-hebrew.ldf

Line 130 in 6239583

\XeTeXinterchartoks \bidi@sepmark@charclass \bidi@digits@charclass = {\DigitsDotDashInterCharToks}

with XeLaTeX.

[jspitz]

Thanks, @moewew. The problem here is that TeX stumbles over a \fi since it doesn't know an \if conditional (\if@nonlatin here), so \ifxetex is closed too early. See https://tex.stackexchange.com/questions/315749/

A solution (which I am going to take) is to use etoolbox's \ifbool rather than \if...\fi switches.

[jspitz]

This is fixed now. @reutenauer I am using the FIXED IN DEV label rather than closing the ticket. This way, other people who encounter the same issue might more easily find this ticket. I propose we close all FIXED IN DEV tickets after the release has been done.

[jspitz]

I think there might be spurious spaces from

polyglossia/tex/gloss-hebrew.ldf

Line 123 in 6239583

\XeTeXinterchartoks \bidi@sepmark@charclass \bidi@digits@charclass = {\xpg@hebrew@DigitsDotDashInterCharToks}

and

polyglossia/tex/gloss-hebrew.ldf

Line 130 in 6239583

\XeTeXinterchartoks \bidi@sepmark@charclass \bidi@digits@charclass = {\DigitsDotDashInterCharToks}

with XeLaTeX.

Thanks, should be addressed at e8e31f8