Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dexlib2 problem in tiktok 27.3+ #2

Closed
d4rkk3y opened this issue Jan 13, 2023 · 3 comments
Closed

dexlib2 problem in tiktok 27.3+ #2

d4rkk3y opened this issue Jan 13, 2023 · 3 comments
Labels
question Further information is requested

Comments

@d4rkk3y
Copy link

d4rkk3y commented Jan 13, 2023

Issue description:

There is a problem in dexlib2 which make the dex from tiktok apk version 27.3+ after read and write back become very big. When I tested it, a dex has size 9MB can become 100MB. Afaik, that is the reason why some people report that they can not patch tiktok version 27.3+ ReVanced/revanced-patches#1358 as multidexlib2 in revanced implement this 9a31b0b. Plus, if they have enough memory the output apk will be very big.

Possible solution:

There is PR JesusFreke/smali#844 that can fix that problem but for some reason it hasn't been merged for a year.
So is it possible to revanced maintain a dexlib2 repo for multidexlib2 and merge this PR?

@oSumAtrIX
Copy link
Member

Is the solution confirmed to solve this issue?

@oSumAtrIX oSumAtrIX added the question Further information is requested label Jan 13, 2023
@d4rkk3y
Copy link
Author

d4rkk3y commented Jan 13, 2023

Is the solution confirmed to solve this issue?

Yes, It is. I tested dexlib2 after merge that PR and the issue is solved. I also tested revanced-cli built with that PR in Tiktok 27.8.1, no memory issue and the output apk size is nearly same with the original apk.

@oSumAtrIX
Copy link
Member

Merged with 115f292.

oSumAtrIX added a commit to ReVanced/revanced-patcher that referenced this issue Jan 15, 2023
oSumAtrIX added a commit to ReVanced/revanced-patches-template that referenced this issue Jan 15, 2023
oSumAtrIX added a commit to ReVanced/revanced-cli that referenced this issue Jan 15, 2023
LeddaZ pushed a commit to LeddaZ/revanced-patches that referenced this issue Jan 17, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants