Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ReVanced(Root) as Magisk module #32

Closed
wants to merge 2 commits into from
Closed

Install ReVanced(Root) as Magisk module #32

wants to merge 2 commits into from

Conversation

yuma2a added 2 commits June 17, 2022 23:44
Install ReVanced-root as magisk-module
We can uninstall revanced easy through Magisk App.
To prevent trouble, old mount scripts in mobile will be removed, automatically.
@oSumAtrIX
Copy link
Member

This PR would force everyone to use Magisk. Currently, the only dependency is the super-user for the root variant. Some people have a super-user but do not have Magisk, for that reason we can not merge this. Always create an issue before you create a PR!

@oSumAtrIX oSumAtrIX closed this Jun 17, 2022
@oSumAtrIX
Copy link
Member

What you can do instead is add the option to use Magisk. This would add more complexity to the code though, either way always create an issue.

@tillnelown
Copy link
Contributor

Am i reading this wrong or does this break multiple patched app installs? Does installing Youtube and then Youtube Music overwrite each other because the scripts seem to be.

@oSumAtrIX
Copy link
Member

The script creates separate mount scripts for each application by its package name.

@HuskyDG
Copy link
Contributor

HuskyDG commented Aug 31, 2022

This PR would force everyone to use Magisk. Currently, the only dependency is the super-user for the root variant. Some people have a super-user but do not have Magisk, for that reason we can not merge this. Always create an issue before you create a PR!

Think about this: you are using /data/adb/post-fs-data.d and /data/adb/service.d which are Magisk specific feature. There are almost no users will use other root solution than Magisk nowaday except for other reason such as debugging, etc or built-in SU, ...
The reason why should we make it as Magisk module is to make it can be easily managed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants