ReturnYouTubeDislike connection statistics. Show client toast messages on RYD connection errors. High priority background threads.

[LisoUseInAIKyrios]

I changed the background thread pool so all threads run at max priority.

This change seems to reduce the average time needed to load the video UI, as the RYD vote fetch now gets priority over other background threads (the fetch is blocking the UI, it definitely should get priority).

Currently this thread pool is only used by RYD for the fetch votes calls.

[oSumAtrIX]

Can you include benchmark results

[LisoUseInAIKyrios]

Benchmarking is not precise since it's affected by whatever is going on in the background, how fast YouTube responds for each video, internet connection speed at that moment, etc, etc, etc.

Without patch. Loading 20 random videos:

revanced: ReturnYouTubeDislike: UI thread paused for: 1071ms waiting for vote fetch to complete
revanced: ReturnYouTubeDislike: UI thread paused for: 1221ms waiting for vote fetch to complete
revanced: ReturnYouTubeDislike: UI thread paused for: 661ms waiting for vote fetch to complete
revanced: ReturnYouTubeDislike: UI thread paused for: 61ms waiting for vote fetch to complete

With patch. Loading same 20 random videos:

revanced: ReturnYouTubeDislike: UI thread paused for: 762ms waiting for vote fetch to complete
revanced: ReturnYouTubeDislike: UI thread paused for: 159ms waiting for vote fetch to complete

[oSumAtrIX]

Unsure if there is any improvement, both benchmarks show similar results.

[LisoUseInAIKyrios]

without the patch, the UI waited 4 out of 20 times.

With the patch, it waited 2 out of 20 times.

It does not log when the UI did not wait.

[oSumAtrIX]

Oh I see, i thought these were samples taken out of the 20.

[LisoUseInAIKyrios]

Another way to view:

• before the patch, the UI was stalled for 3,014ms to load 20 videos
• after the patch, the UI was stalled for 921ms to load 20 videos.

[LisoUseInAIKyrios]

I added logging to the API network calls, and added user viewable statistics if debugging is enabled:
https://freeimage.host/i/HoDNhKB

Also added a Toast if a connection times out, or if a rate limit is encountered.

[oSumAtrIX]

Thanks!

[github-actions]

🎉 This PR is included in version 0.86.0 🎉

The release is available on:

• v0.86.0
• GitHub release

Your semantic-release bot 📦🚀