Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updater): download successful dialog #938

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Conversation

TheAabedKhan
Copy link
Member

When a user knowingly or unknowingly cancels or closes the installer window, there must be a dialog box which allows the user to launch the installer window again.
revanced_ui

@ILoveOpenSourceApplications
Copy link

If this UI/UX change is the same as the screenshot, then I would like to suggest some changes. "Update downloaded!" text being shown in place of the progress bar, could be placed in the position of "downloading update...". Once the download completes, the text could change into "Download completed"/"Update downloaded" and then the user can update by tapping the update button.

@Ushie Ushie changed the title feat: improve UI/UX for updateManager. feat(updater): download successful dialog Jun 13, 2023
@Ushie Ushie changed the base branch from main to dev June 15, 2023 09:55
@Ushie
Copy link
Member

Ushie commented Jun 15, 2023

After you resolve the issue raised in the comment above, this can be merged

@TheAabedKhan
Copy link
Member Author

TheAabedKhan commented Jun 15, 2023

New UI after fixes. Please have a look, @Ushie

revanced_updater_new

@Ushie
Copy link
Member

Ushie commented Jun 15, 2023

Maybe the Update button should be renamed to Install instead?

@TheAabedKhan
Copy link
Member Author

The package installer shows Update and Cancel, so the UI also has the same options. Let me know if I should replace the Update to Install anyway.

@Ushie
Copy link
Member

Ushie commented Jun 15, 2023

I think the progress bar doesn't need to be there anymore, what about text instead? "Do you want to install this update?" or something along the lines of that

@TheAabedKhan
Copy link
Member Author

@Ushie check the recent commit.

@ILoveOpenSourceApplications

Maybe the Update button should be renamed to Install instead?

I second this. Why press update twice, when downloading and installing.

I think the progress bar doesn't need to be there anymore, what about text instead? "Do you want to install this update?" or something along the lines of that

Would make more sense with this as well.

@TheAabedKhan
Copy link
Member Author

"Do you want to install this update?" or something along the lines of that

The package installer will automatically open after the update is downloaded so a user can't see what's written on the dialog box. If the user mistakenly cancels the installer, then the user can see the text that says, "Continue to install the update?" which makes more sense.

@Ushie
Copy link
Member

Ushie commented Jun 15, 2023

That text sounds good

@Ushie
Copy link
Member

Ushie commented Jun 22, 2023

Have you been able to make time to update the text?

@Ushie Ushie marked this pull request as draft June 22, 2023 21:58
@TheAabedKhan
Copy link
Member Author

Have you been able to make time to update the text?

What text to what?

@Ushie
Copy link
Member

Ushie commented Jun 23, 2023

Oh my mistake, completely missed that commit

@Ushie Ushie marked this pull request as ready for review June 23, 2023 13:36
@Ushie Ushie merged commit d051ae5 into ReVanced:dev Jun 23, 2023
2 checks passed
@TheAabedKhan TheAabedKhan deleted the patch-1 branch July 7, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants