Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(patches-selector): Improve disabled card UI #941

Merged
merged 2 commits into from
Jun 15, 2023
Merged

feat(patches-selector): Improve disabled card UI #941

merged 2 commits into from
Jun 15, 2023

Conversation

ponces
Copy link
Contributor

@ponces ponces commented Jun 12, 2023

This includes hiding the "Warning" label on the disabled card as interacting with it only makes sense on an enabled card.

Before vs After:
Screenshot_20230612-221638

@oSumAtrIX
Copy link
Member

How will the user understand, why it is greyed out?

@ponces
Copy link
Contributor Author

ponces commented Jun 12, 2023 •
edited

They will try to interact with it and the toast will clearly say it why.
Having an interactable subcomponent inside a non-interactable component does not make sense at all...

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jun 12, 2023 •
edited

The UI will not motivate the user to interact with it. The user will take for granted that it is unavailable but not know why. Before, the user was motivated by the interactive chip.

@ponces
Copy link
Contributor Author

ponces commented Jun 12, 2023

The UI will not motivate the user to interact with it. The user will take for granted that it is unavailable but not know why. Before, the user was motivated by the interactive chip.

That's not true. The user is always tempted to click it anyway just to see what happens.
In fact, I only knew about the toast because I tried to interact with the greyed out card.
Yet again:

Having an interactable subcomponent inside a non-interactable component does not make sense at all...

Aunali321
Aunali321 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@Aunali321 Aunali321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning makes sense. Looks good to me.

validcube
validcube approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks good to me!

@Ushie Ushie changed the title feat: Improve disabled card UI on Patches Selector feat(patches-selector): Improve disabled card UI Jun 13, 2023
@ponces
Copy link
Contributor Author

ponces commented Jun 15, 2023

Is anything missing?

@Ushie Ushie changed the base branch from main to dev June 15, 2023 09:33
@Ushie Ushie merged commit b161608 into ReVanced:dev Jun 15, 2023
2 checks passed
@ponces ponces deleted the improve-disabled-card-ui branch June 15, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aunali321 Aunali321 Aunali321 approved these changes

@validcube validcube validcube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ponces @oSumAtrIX @Aunali321 @validcube @Ushie