feat(app-selector): Improve app item UI to avoid overflow issues #943
Conversation
| : 'v${widget.installedVersion}', | ||
| ), | ||
| ], | ||
| Text( |
There was a problem hiding this comment.
Why was the Row removed? Semantically each line of text should be a row item
There was a problem hiding this comment.
That's because the installed version is shown right above the suggested version. The Row used to contain the app's name and its installed version. Now that they are separated from each other, the Row is no longer needed.
There was a problem hiding this comment.
What if the device is widescreen? Won't the items stop to be wrapped and showed next to each other? Using Row and Columns usually also are also done for semantical reasons. If you know that you want to show a line of text below another, you use a row of those items
There was a problem hiding this comment.
I could have used Wrap as well, but I guess the Installed version and the Suggested version should be next to each other. Also, before #934, there was no Row
Before vs After