Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: experimental patches stay selected when toggled off #946

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

TheAabedKhan
Copy link
Member

@TheAabedKhan TheAabedKhan commented Jun 15, 2023

This PR fixes the issue with unsupported patches not being unselected even after the Experimental patches support is turned off.

Reproduce the issue by turning on Experimental patches support first, then select any unsupported patches and click done. Now, turn off the experimental patches support. Check the selected patches list and length is the same.

@TheAabedKhan TheAabedKhan changed the title fix: unsupported patches keep being selected fix: experimental patches support toggle Jun 15, 2023
@Ushie Ushie changed the base branch from main to dev June 22, 2023 22:01
@Ushie Ushie changed the title fix: experimental patches support toggle fix: experimental patches stay selected when toggled off Jun 22, 2023
@Ushie
Copy link
Member

Ushie commented Jun 22, 2023

May you resolve the conflicts?

@TheAabedKhan
Copy link
Member Author

@Ushie, done!

@Ushie Ushie merged commit 716a30b into ReVanced:dev Jun 23, 2023
1 check passed
@TheAabedKhan TheAabedKhan deleted the patch-7 branch July 7, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants