Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use /data/adb/revanced again and ensure migration scenario #948

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: Use /data/adb/revanced again and ensure migration scenario #948

merged 1 commit into from
Jun 22, 2023

Conversation

ponces
Copy link
Contributor

@ponces ponces commented Jun 15, 2023 •
edited

Closes #283, #515 and #860.

@ponces
Copy link
Contributor Author

ponces commented Jun 19, 2023 •
edited

Edited original message to mention issues which should be closed with this merge.
Later, I'll push new PR's to fix legacy devices mount issues like it's mentioned on #540 and a proper cleaning of /data/adb/revanced, data/adb/post-fs-data.d/<package>.sh and /data/adb/service.d/<package>.sh.

@ponces
Copy link
Contributor Author

ponces commented Jun 21, 2023

Any news on this?

@oSumAtrIX oSumAtrIX requested a review from Aunali321 June 21, 2023 09:57
Aunali321
Aunali321 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@Aunali321 Aunali321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, Thanks!

@ponces
Copy link
Contributor Author

ponces commented Jun 21, 2023

Approved, Thanks!

? What? It was already approved by you...

@Ushie Ushie merged commit 35e99cb into ReVanced:dev Jun 22, 2023
1 check passed
@Ushie
Copy link
Member

Ushie commented Jun 22, 2023

Thank you pomses!

@ponces ponces deleted the revert-to-data-adb-path branch June 22, 2023 23:44
@ILoveOpenSourceApplications
Copy link

@Ushie, the issues mentioned here which will be resolved/closed with this commit are still left open. Any reason for that?

@oSumAtrIX
Copy link
Member

@ILoveOpenSourceApplications this is because

  • The closing syntax is not followed in the description of the PR
  • The native feature by GitHub is not used:
    Screenshot_2023-07-13-13-35-55-74_984e1414ae90666a90f12ff17ec14a7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aunali321 Aunali321 Aunali321 approved these changes

@validcube validcube Awaiting requested review from validcube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ponces @Ushie @ILoveOpenSourceApplications @oSumAtrIX @Aunali321