docs: small changes #950
Merged
docs: small changes #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging footnote 1 and 4; some more clarity for step 6
and hopefully no semantics error lol
oSumAtrIX
reviewed
Jun 16, 2023
|
|
||
| [^1]: You may be prompted to select an app from storage in case you have no root access on your device. In this case, select the APK file from your device storage.[^3] | ||
| [^1]: Non-root users may be prompted to select an APK from storage, in which case you have to source the APK file yourself. ReVanced does not provide any APK files. |
There was a problem hiding this comment.
The information about having to source APK files yourself should be added to the step where the user needs to select an app. When they already selected one and are already in the installation screen, what use has the footnote about them having to source the APK file.
There was a problem hiding this comment.
Is that not currently the case? Footnote 1 mentions that and is attached to step 3, where the user needs to select an app. That would also be the exact point where they might be prompted about non-root installation, giving an incentive to read this footnote, to realize that they have to select from storage and have to source it themselves.
oSumAtrIX
approved these changes
Jun 17, 2023
ponces
pushed a commit
to ponces/revanced-manager
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging footnote 1 and 4; some more clarity for step 6