fix: clear method lookup maps #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
changed the title
revanced-bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
## [11.0.4-dev.1](v11.0.3...v11.0.4-dev.1) (2023-07-01) ### Bug Fixes * clear method lookup maps ([#198](#198)) ([9d81baf](9d81baf))
|
A proper deconstructor does not exist yet for ReVanced Patcher. Currently, ReVanced Patcher is "use-once". After you supply patches and patches, the patches can not be reused to patch again because they keep their state. The entire class loader used to load the classes has to be deleted, and a new one has to be used. A similar state issue exists with ReVanced Patcher. |
revanced-bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
## [11.0.4](v11.0.3...v11.0.4) (2023-07-01) ### Bug Fixes * clear method lookup maps ([#198](#198)) ([9d81baf](9d81baf))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the patcher stays in memory, patching in Manager multiple times (without restarting the app) always fails on the second patch. The lookup maps to be cleared after patching finishes.
This fix should be pushed out now, and Manager needs another dependency update and release.