fix: bugfixes in microg

ReVanced · May 26, 2022 · a43b33b · a43b33b
1 parent 7bc6094
commit a43b33b
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 31 deletions.
diff --git a/src/main/kotlin/app/revanced/extensions/Extensions.kt b/src/main/kotlin/app/revanced/extensions/Extensions.kt
@@ -18,5 +18,13 @@ internal fun String.startsWithAny(vararg prefix: String): Boolean {
         if (this.startsWith(_prefix))
             return true
 
+    return false
+}
+
+internal fun String.containsAny(vararg others: String): Boolean {
+    for (other in others)
+        if (this.contains(other))
+            return true
+
     return false
 }
diff --git a/...ain/kotlin/app/revanced/patches/youtube/misc/microg/patch/bytecode/MicroGBytecodePatch.kt b/...ain/kotlin/app/revanced/patches/youtube/misc/microg/patch/bytecode/MicroGBytecodePatch.kt
@@ -1,5 +1,6 @@
 package app.revanced.patches.youtube.misc.microg.patch.bytecode
 
+import app.revanced.extensions.containsAny
 import app.revanced.extensions.startsWithAny
 import app.revanced.patcher.annotation.Description
 import app.revanced.patcher.annotation.Name
@@ -54,19 +55,20 @@ class MicroGBytecodePatch : BytecodePatch(
                 val implementation = method.implementation ?: return@methodLoop
 
                 var proxiedImplementation: MutableMethodImplementation? = null
-
                 implementation.instructions.forEachIndexed { i, instruction ->
-                    if (instruction.opcode == Opcode.CONST_STRING) {
-                        val stringValue = ((instruction as Instruction21c).reference as StringReference).string
+                    if (instruction.opcode != Opcode.CONST_STRING) return@forEachIndexed
 
-                        val replaceMode = if (stringValue == "com.google" || stringValue.startsWithAny(
-                                "com.google.android.gms.auth.accounts",
+                    val stringValue = ((instruction as Instruction21c).reference as StringReference).string
+
+                    val replaceMode =
+                        if (stringValue == "com.google" || stringValue == "com.google.android.gms" ||
+                            stringValue.startsWithAny(
+                                "com.google.iid",
                                 "com.google.android.gms.chimera",
                                 "com.google.android.c2dm",
-                                "com.google.android.c2dm",
+                            ) || stringValue.containsAny(
+                                "com.google.android.gms.auth.accounts",
                                 "com.google.android.gsf",
-                                "com.google.android.c2dm",
-                                "com.google.iid",
                                 "content://com.google.settings"
                             )
                         ) {
@@ -83,30 +85,27 @@ class MicroGBytecodePatch : BytecodePatch(
                             StringReplaceMode.DO_NOT_REPLACE
                         }
 
+                    if (replaceMode != StringReplaceMode.DO_NOT_REPLACE) {
+                        if (proxiedClass == null) {
+                            proxiedClass = data.proxy(classDef).resolve()
+                        }
 
-                        if (replaceMode != StringReplaceMode.DO_NOT_REPLACE) {
-                            if (proxiedClass == null) {
-                                proxiedClass = data.proxy(classDef).resolve()
-                            }
-
-                            if (proxiedImplementation == null) {
-                                proxiedImplementation = proxiedClass!!.methods.first {
-                                    it.name == method.name && it.parameterTypes.containsAll(method.parameterTypes)
-                                }.implementation!!
-                            }
+                        if (proxiedImplementation == null) {
+                            proxiedImplementation = proxiedClass!!.methods.first {
+                                it.name == method.name && it.parameterTypes.containsAll(method.parameterTypes)
+                            }.implementation!!
+                        }
 
-                            val newString =
-                                if (replaceMode == StringReplaceMode.REPLACE_WITH_REVANCED) stringValue.replace(
-                                    "com.google.android.youtube", REVANCED_PACKAGE_NAME
-                                )
-                                else stringValue.replace("com.google", BASE_MICROG_PACKAGE_NAME)
+                        val newString = if (replaceMode == StringReplaceMode.REPLACE_WITH_REVANCED) stringValue.replace(
+                            "com.google.android.youtube", REVANCED_PACKAGE_NAME
+                        )
+                        else stringValue.replace("com.google", BASE_MICROG_PACKAGE_NAME)
 
-                            proxiedImplementation!!.replaceInstruction(
-                                i, BuilderInstruction21c(
-                                    Opcode.CONST_STRING, instruction.registerA, ImmutableStringReference(newString)
-                                )
+                        proxiedImplementation!!.replaceInstruction(
+                            i, BuilderInstruction21c(
+                                Opcode.CONST_STRING, instruction.registerA, ImmutableStringReference(newString)
                             )
-                        }
+                        )
                     }
                 }
             }
@@ -126,9 +125,6 @@ class MicroGBytecodePatch : BytecodePatch(
             "const-string v0, \"com.google.android.gms\"".toInstruction()
         )
 
-        // allow GC to clean unused/ replaced immutable class definitions after this call
-        data.classes.applyProxies()
-
         return PatchResultSuccess()
     }