-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: announcement patch #1047
Comments
Would be nice if it could notify us only on bugfix updates or something |
A bare minimum v0 implemention of this, is to have a "minimum patch version" that's stored on GitHub or the ReVanced API. Then update the minimum patch version when a required fix is released (such as fixes to signature spoofing). Then in integrations patch, check at most once a day to see if the client is outdated. Patched instances older than this minimum version will see a dialog message prompting to update because their app no longer works reliably. This would be the simplest possible v0 implemention that's desperately needed to solve the use case of users who rarely update. Would take less than an hour to code up, and a more robust change log based notification (similar to what manager shows) could be done later. It's so painful when users go on the usual: |
I believe a proper implementation isn't far away from a v0 implementation. Patch-wise, only an API has to be consumed and displayed in a popup. The announcements API itself is specified as follows: ReVanced/revanced-api#42 |
Implemented with #3166 |
The request is to enable it on other apps than YT |
Ahh, gotcha |
# [2.111.0](ReVanced/revanced-patches@v2.110.0...v2.111.0) (2022-11-15) ### Features * **iconpackstudio:** `unlock-pro` patch ([ReVanced#1047](ReVanced/revanced-patches#1047)) ([fcbca9c](ReVanced/revanced-patches@8a7c377))
Application
Youtube (music) or possibly all aps
Issue
People dont know a updated version of the patch is out, hence don't update and missed some bug fixes, causing issues and asking for tech support.
Related: #1752 (comment)
Patch
Adding an announcement channel that, when there is an update release, popup/notify the user with sysyem notification/popup. User can optionally select "ignore this version"
Motivation
Reduce wasted time on tech support due to not using latest version.
Acknowledgements
The text was updated successfully, but these errors were encountered: