Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: announcement patch #1047

Open
3 tasks done
SodaWithoutSparkles opened this issue May 2, 2023 · 6 comments
Open
3 tasks done

feat: announcement patch #1047

SodaWithoutSparkles opened this issue May 2, 2023 · 6 comments
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@SodaWithoutSparkles
Copy link
Contributor

Application

Youtube (music) or possibly all aps

Issue

People dont know a updated version of the patch is out, hence don't update and missed some bug fixes, causing issues and asking for tech support.

Related: #1752 (comment)

Patch

Adding an announcement channel that, when there is an update release, popup/notify the user with sysyem notification/popup. User can optionally select "ignore this version"

Motivation

Reduce wasted time on tech support due to not using latest version.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@SodaWithoutSparkles SodaWithoutSparkles added the Feature request Requesting a new feature that's not implemented yet label May 2, 2023
@oSumAtrIX oSumAtrIX self-assigned this May 3, 2023
@mskiptr
Copy link

mskiptr commented May 6, 2023

Would be nice if it could notify us only on bugfix updates or something

@LisoUseInAIKyrios
Copy link
Contributor

A bare minimum v0 implemention of this, is to have a "minimum patch version" that's stored on GitHub or the ReVanced API. Then update the minimum patch version when a required fix is released (such as fixes to signature spoofing).

Then in integrations patch, check at most once a day to see if the client is outdated. Patched instances older than this minimum version will see a dialog message prompting to update because their app no longer works reliably.

This would be the simplest possible v0 implemention that's desperately needed to solve the use case of users who rarely update. Would take less than an hour to code up, and a more robust change log based notification (similar to what manager shows) could be done later.

It's so painful when users go on the usual:
"My revanced is broken and it's buffering. What do I do? ...my app is up to date, I installed it 6 months ago!" 🤦🏻‍♂️

@oSumAtrIX
Copy link
Member

I believe a proper implementation isn't far away from a v0 implementation. Patch-wise, only an API has to be consumed and displayed in a popup. The announcements API itself is specified as follows: ReVanced/revanced-api#42

@LisoUseInAIKyrios
Copy link
Contributor

Implemented with #3166

@oSumAtrIX
Copy link
Member

The request is to enable it on other apps than YT

@oSumAtrIX oSumAtrIX reopened this Nov 5, 2023
@LisoUseInAIKyrios
Copy link
Contributor

Ahh, gotcha

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants