Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End cards are not showing regardless of the settings used #1076

Closed
2 of 3 tasks
SodaWithoutSparkles opened this issue Apr 28, 2023 · 3 comments
Closed
2 of 3 tasks

End cards are not showing regardless of the settings used #1076

SodaWithoutSparkles opened this issue Apr 28, 2023 · 3 comments
Labels
Bug report Something isn't working

Comments

@SodaWithoutSparkles
Copy link
Contributor

SodaWithoutSparkles commented Apr 28, 2023 •
edited by oSumAtrIX
Loading

Type

Error at runtime

Bug description

End cards are not showing regardless of the settings used

Steps to reproduce

  1. Patch YT with 2.171.0 with all recommended patches
  2. Disable "hide end screen cards" in revanced > layout
  3. Watch this test video
  4. End cards are expected to appear at around 0:20, but they are not there

Relevant log output

N/A

Screenshots or videos

Screenshot_2023-04-28-14-45-41-192_com android chrome-edit
Screenshot_2023-04-28-14-44-55-640_app revanced android youtube-edit

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@SodaWithoutSparkles SodaWithoutSparkles added the Bug report Something isn't working label Apr 28, 2023
@LisoUseInAIKyrios
Copy link
Contributor

It's a side effect of spoofing signature verification.

@SodaWithoutSparkles
Copy link
Contributor Author

SodaWithoutSparkles commented Apr 28, 2023 •
edited
Loading

So this is a documentation problem then.

I hereby suggest the description of signiture verification in revanced settings should mention all known side effects.

Should I open another issue or...?

@LisoUseInAIKyrios
Copy link
Contributor

Post in the suggestion in #1752

@SodaWithoutSparkles SodaWithoutSparkles mentioned this issue Apr 28, 2023
Closed
13 tasks
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.112.0 [skip ci]
a42b849 
# [2.112.0](ReVanced/revanced-patches@v2.111.3...v2.112.0) (2022-11-19)

### Features

* **anytracker:** `unlock-premium` patch ([ReVanced#1076](ReVanced/revanced-patches#1076)) ([52b3d90](ReVanced/revanced-patches@8122717))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SodaWithoutSparkles @LisoUseInAIKyrios