Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Hide end screen cards options broken #1088

Closed
3 tasks done
AMSAMSAMSAMS opened this issue Apr 27, 2023 · 1 comment
Closed
3 tasks done

bug: Hide end screen cards options broken #1088

AMSAMSAMSAMS opened this issue Apr 27, 2023 · 1 comment
Labels
Bug report Something isn't working

Comments

@AMSAMSAMSAMS
Copy link

AMSAMSAMSAMS commented Apr 27, 2023

Type

Other

Bug description

The setting is not honoured at all.
No matter what the settings are, enabled/disabled, the end screen cards always hidden.

Also affects the info cards settings.

CLI: 2.20.1
Patches: 2.170.0
Integrations: 0.104.0
YT: 18.15.40

sudo java -jar revanced-cli--all.jar -a com.google.android.youtube_.apk -c -o ReVanced.apk -b revanced-patches-.jar -m revanced-integrations-.apk -e custom-branding -e theme -e amoled

Steps to reproduce

Try to play any video with info cards or end screen cards & see youself.

Relevant log output

.

Screenshots or videos

Here's the screenshot with the [hide end screen cards], [hide info cards], [hide info panel] all disabled.
The only options enabled is just [Hide cast button].

tempFileForShare_20230427-091647

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@AMSAMSAMSAMS AMSAMSAMSAMS added the Bug report Something isn't working label Apr 27, 2023
@oSumAtrIX
Copy link
Member

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants