Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use consistent patch descriptions #1135

Closed
3 tasks done
xafn opened this issue Apr 19, 2023 · 1 comment
Closed
3 tasks done

fix: use consistent patch descriptions #1135

xafn opened this issue Apr 19, 2023 · 1 comment
Labels
Bug report Something isn't working

Comments

@xafn
Copy link

xafn commented Apr 19, 2023

Type

Cosmetic

Bug description

Patches have an inconsistent writing style of descriptions.

Some issues I have observed:

  1. Some patch descriptions include the name of the targeted app, while other patches for it do not.
  2. Related patches for different applications have slightly different descriptions, when they should all be consistent. https://user-images.githubusercontent.com/47723802/232953871-dfb06072-3a4b-4a12-8bce-7e3f022a11ed.png
  3. Some patches have plain grammar/spelling mistakes. https://user-images.githubusercontent.com/47723802/232954212-1c6f7498-e1e7-4df1-8ad7-4dea991993f9.png

Steps to reproduce

n/a

Relevant log output

n/a

Screenshots or videos

No response

Solution

Introduce description rules to the patches documentation. This will ensure all descriptions remain consistent.

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@xafn xafn added the Bug report Something isn't working label Apr 19, 2023
@oSumAtrIX oSumAtrIX changed the title docs: restore patch description consistency fix: restore patch description consistency Apr 19, 2023
@oSumAtrIX oSumAtrIX changed the title fix: restore patch description consistency fix: use consistent patch descriptions Apr 19, 2023
@oSumAtrIX
Copy link
Member

ReVanced/revanced-patches-template#740

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.126.1 [skip ci]
43d6281 
## [2.126.1](ReVanced/revanced-patches@v2.126.0...v2.126.1) (2022-11-28)

### Bug Fixes

* **youtube/custom-video-speed:** fuzzy scan on fingerprint  ([ReVanced#1135](ReVanced/revanced-patches#1135)) ([7b2cf56](ReVanced/revanced-patches@3e7dbc1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oSumAtrIX @xafn