Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Remember video quality): 1080p quality is sometimes used when default quality is set to 1440p or higher #118

Closed
3 tasks done
CyanWool opened this issue Nov 12, 2023 · 9 comments
Labels
Bug report Something isn't working

Comments

@CyanWool
Copy link

CyanWool commented Nov 12, 2023

Bug description

If you watch a video that has has a maximum video quality of 1080p and then watch a 4k video the quality will stay at 1080p despite higher qualities being avaliable.

The problem temporarily fixes itself if you close the video and reopen again or set quality manually but will will happen again next time you watch a video below your set default and then another where it is avaliable.

Error logs

No response

Solution

No response

Additional context

Timeline on how to reproduce bug:

  1. Watch a 1080p video with stats for nerds enabled (that you haven't manually set the quality for previously)
  2. Close the video
  3. Watch a 4k video
  4. Stats for nerds will confirm the quality has maxed out at 1080p - the quality of the previous video no matter how long you let the video play.

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@CyanWool CyanWool added the Bug report Something isn't working label Nov 12, 2023
@LisoUseInAIKyrios
Copy link
Contributor

Are you looking at the 'viewport' or the 'video format' stat?

The default video quality can take a few seconds for it to become active. This is true even with stock YouTube where changing the quality will immediately show the new resolution in the quality picker, but the stats for nerds shows the quality actually changes after playing the video briefly.

@CyanWool
Copy link
Author

I'm looking at the video format, i can also confirm by pressing the quality button and it will have 1080p ticked despite higher qualities listed above it, stats for nerds was just a quick way to tell when switching videos.
I know it can take a few seconds or more to start playing at full quality but even then at will cap out at the max quality of the previous video.

@LisoUseInAIKyrios
Copy link
Contributor

Post a screen recording video that reproduces the issue

@CyanWool
Copy link
Author

CyanWool commented Nov 12, 2023

Post a screen recording video that reproduces the issue

Sure https://drive.google.com/file/d/1PZvkkDB8Ppso2vdFIAp9E80VTEVYVPdA/view?usp=drivesdk

Edit: Also if it helps i am using youtube 18.38.44 on a galaxy tab s8+

@LisoUseInAIKyrios
Copy link
Contributor

I was able to reproduce the issue, but only if the YT video quality setting is 'automatic' and the ReVanced default quality is set to 2k.

It appears YT might be changing to 1080p quality after the video starts, because the stats for nerds shows the second video quality is briefly set to 2k before changing to 1080p. Need to look at the logs to figure out more.

For now try setting the YT video quality preference to 'higher picture quality' and that might help.

@CyanWool
Copy link
Author

I double checked and I do have higher quality set but I tried again on auto and high quality with the same result but thanks for your help tracking this down, its not a massive issue as I can just close and open the video to fix it each time or just set the quality manually.

@LisoUseInAIKyrios
Copy link
Contributor

Also try 1440p default quality. And try using app version spoofing to 18.20.39 (it uses the older video quality picker).

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: Default video quality gets stuck at the maximum quality of the previous video despite 2160p default set bug(YouTube - Remember video quality): 1080p quality is sometimes used when default quality is set to 1440p or higher Nov 12, 2023
@CyanWool
Copy link
Author

CyanWool commented Nov 12, 2023

While I'm still getting the same behaviour after spoofing to 18.20.39 stats for nerds does sit on 1440p for a few seconds before going to 1080, don't think it was actually at 1440p for that time though.
I have done it a few times and it sits at 1440p for a few seconds each time, still unsure if it's actually going to it for that brief time.

Edit: maybe we are getting different results because of the device resolution or the android version causing different behaviour as I can reproduce this 100% of the time

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
@LisoUseInAIKyrios
Copy link
Contributor

Closing as this is basically the same issue as #2675

@LisoUseInAIKyrios LisoUseInAIKyrios closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants