Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: YT Music - Patching seems to work, but app is unchanged #1401

Closed
3 tasks done
Jdbye opened this issue Jan 27, 2023 · 2 comments
Closed
3 tasks done

bug: YT Music - Patching seems to work, but app is unchanged #1401

Jdbye opened this issue Jan 27, 2023 · 2 comments
Labels
Bug report Something isn't working

Comments

@Jdbye
Copy link

Jdbye commented Jan 27, 2023

Type

Error at runtime

Bug description

Patching seems to work, no errors, app starts up but looks the same as normal, no extra settings to be found or anything like that.

CLI: revanced-cli-2.20.0-all.jar
Patches: revanced-patches-2.156.0.jar
Integrations: revanced-integrations-0.93.1.apk
YT Music: com.google.android.apps.youtube.music_5.39.52-53952240_minAPI21(arm64-v8a)(nodpi)_apkmirror.com.apk

Steps to reproduce

Used the following command: d:\Stuff\revanced\zulu17.40.19-ca-jre17.0.6-win_x64\bin\java.exe -jar D:\Stuff\revanced\revanced-cli-2.20.0-all.jar -b D:\Stuff\revanced\revanced-patches-2.156.0.jar -m D:\Stuff\revanced\revanced-integrations-0.93.1.apk -a D:\Stuff\revanced\com.google.android.apps.youtube.music_5.39.52-53952240_minAPI21(arm64-v8a)(nodpi)_apkmirror.com.apk -c -o D:\Stuff\revanced\youtubemusic-revanced-output.apk -e microg-support -e music-microg-support -e always-autorepeat -e comments -e compact-header -e disable-fullscreen-panels -e hide-autoplay-button -e hide-captions-button -e hide-email-address -e hide-endscreen-cards -e hide-info-cards -e hide-time-and-seekbar -e hide-views-stats -e spoof-app-version -i remove-screenshot-restriction -d N7AIOC035345YKG --mount

Relevant log output

INFO: Reading dex files
INFO: Decoding AndroidManifest.xml only, because resources are not needed
INFO: Merging D:\Stuff\revanced\revanced-integrations-0.93.1.apk
INFO: Skipping compact-header: Manually excluded
INFO: Skipping music-microg-support: Manually excluded
INFO: Skipping predictive-back-gesture: Excluded by default
INFO: background-play succeeded
INFO: codecs-unlock succeeded
INFO: exclusive-audio-playback succeeded
INFO: hide-get-premium succeeded
INFO: minimized-playback-music succeeded
INFO: music-video-ads succeeded
INFO: remove-screenshot-restriction succeeded
INFO: tasteBuilder-remover succeeded
INFO: upgrade-button-remover succeeded
INFO: Not compiling resources because resource patching is not required
INFO: Writing modified dex files
INFO: Aligning com.google.android.apps.youtube.music_5.39.52-53952240_minAPI21(arm64-v8a)(nodpi)_apkmirror.com.apk to youtubemusic-revanced-
output_aligned.apk
INFO: Copying youtubemusic-revanced-output_aligned.apk to youtubemusic-revanced-output.apk
INFO: Failed to clean up cache directory
INFO: Installing by mounting
01-27 03:14:37.558 15019 15019 D AndroidRuntime: Shutting down VM
01-27 03:14:37.594 15076 15076 D AndroidRuntime: >>>>>> START com.android.internal.os.RuntimeInit uid 0 <<<<<<
01-27 03:14:37.596 15076 15076 I AndroidRuntime: Using default boot image
01-27 03:14:37.596 15076 15076 I AndroidRuntime: Leaving lock profiling enabled
01-27 03:14:37.596 15076 15076 D AndroidRuntime: small ram device
01-27 03:14:37.668 15076 15076 D AndroidRuntime: Calling main entry com.android.commands.content.Content
01-27 03:14:37.675 15076 15076 D AndroidRuntime: Shutting down VM
01-27 03:14:38.092 15231 15231 D AndroidRuntime: >>>>>> START com.android.internal.os.RuntimeInit uid 0 <<<<<<
01-27 03:14:38.094 15231 15231 I AndroidRuntime: Using default boot image
01-27 03:14:38.094 15231 15231 I AndroidRuntime: Leaving lock profiling enabled
01-27 03:14:38.094 15231 15231 D AndroidRuntime: small ram device
01-27 03:14:38.162 15231 15231 D AndroidRuntime: Calling main entry com.android.commands.content.Content
01-27 03:14:38.170 15231 15231 D AndroidRuntime: Shutting down VM

Screenshots or videos

No response

Solution

No response

Additional context

YouTube app works fine with a similar command, so I don't understand why YT Music isn't working.
I have installed the correct version beforehand, so the version matches.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Jdbye Jdbye added the Bug report Something isn't working label Jan 27, 2023
@oSumAtrIX
Copy link
Member

I don't know what you mean; there are no settings included for the patches in the app. If you still see ads, then something went wrong. Try the non-root variant and report back.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-cli Jan 27, 2023
@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Jan 27, 2023
@Jdbye
Copy link
Author

Jdbye commented Jan 27, 2023

OK, that's fair, I just assumed it would have some kind of UI similar to YouTube Revanced. But I expected it to have a custom icon at least. There's just no indication that anything changed, so you can probably understand my confusion.
Background playback seems to be working though, and I don't see any ads yet, so I guess it's working.
Also, seems I posted this in the wrong repo, meant to post it in revanced-cli... But I guess it's more related to this repo after all.
Thanks for clearing things up, in any case.

@ILoveOpenSourceApplications ILoveOpenSourceApplications removed the Waiting on author Further information is requested label Mar 29, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
## [2.149.1-dev.1](ReVanced/revanced-patches@v2.149.0...v2.149.1-dev.1) (2022-12-30)

### Bug Fixes

* **youtube/bottom-controls-resource-patch:** use correct length for `nameSpaceLength` ([ReVanced#1401](ReVanced/revanced-patches#1401)) ([7190066](ReVanced/revanced-patches@071fc7a))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.150.0](ReVanced/revanced-patches@v2.149.0...v2.150.0) (2022-12-31)

### Bug Fixes

* **youtube/bottom-controls-resource-patch:** use correct length for `nameSpaceLength` ([ReVanced#1401](ReVanced/revanced-patches#1401)) ([7190066](ReVanced/revanced-patches@071fc7a))
* **youtube/general-ads:** resolve fingerprint to correct method ([ReVanced#1404](ReVanced/revanced-patches#1404)) ([e135485](ReVanced/revanced-patches@f2f7593))

### Features

* **youtube/return-youtube-dislike:** better formatting and LTR support  ([ReVanced#1370](ReVanced/revanced-patches#1370)) ([fd0fe1c](ReVanced/revanced-patches@ae167f5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants