Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(youtube): different playback rate for youtube music videos #1464

Closed
3 tasks done
SodaWithoutSparkles opened this issue Jan 9, 2023 · 4 comments
Closed
3 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@SodaWithoutSparkles
Copy link
Contributor

Application

Youtube

Issue

People don't often play music videos or listen to music with the same playback speed as other videos

Patch

Use a different entry for youtube videos with type music. This in theory can be detected as sponsorblock has a special music type.

Motivation

It's very annoying to change the playback rate for music videos, which takes a couple seconds and I have to go back to the start and re-watch it.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@SodaWithoutSparkles SodaWithoutSparkles added the Feature request Requesting a new feature that's not implemented yet label Jan 9, 2023
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title Different playback rates for youtube videos type music feat(youtube): different playback rate for youtube music videos Jun 26, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
@megamorphg
Copy link

This would only address some videos because there are a lot of "music" videos like dance videos that aren't categorized as music. It's probably better to implement this as #977 instead.

@SodaWithoutSparkles
Copy link
Contributor Author

SodaWithoutSparkles commented Jan 30, 2024

This would only address some videos because there are a lot of "music" videos like dance videos that aren't categorized as music. It's probably better to implement this as #977 instead.

It might not be appropriate to mark the whole channel, as there are also a number of channels with mixed contents. For example, vtuber channels often contain not only music type, but also gaming, live stream (replays), etc. There are also anime related channels that post non-music contents but still has a couple of music (type) videos

Edit: I am not saying the whole idea of #977 is flawed, just that it is not as clear cut as it might seem.

@megamorphg
Copy link

Yeah, maybe there could be an additional setting on this speed control page "Sponsorblock music 1x speed" where if Sponsorblock marks the video as music, it over-rides to 1x regardless of the channel's speed settings (unless manually over-ridden).

Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.154.0-dev.1](ReVanced/revanced-patches@v2.153.0...v2.154.0-dev.1) (2023-01-10)

### Bug Fixes

* **youtube/hide-info-cards:** allow toggling visibility of info-cards ([ReVanced#1464](ReVanced/revanced-patches#1464)) ([e6dcb55](ReVanced/revanced-patches@cb89688))

### Features

* `remove-screenshot-restriction` patch ([ReVanced#1455](ReVanced/revanced-patches#1455)) ([a16ab79](ReVanced/revanced-patches@5c1cd0b))
* **music:** update patches compatibility to v5.38.53 ([ReVanced#1453](ReVanced/revanced-patches#1453)) ([c7d116a](ReVanced/revanced-patches@3d316e9))
* **youtube/return-youtube-dislike:** style for minimum width ([ReVanced#1454](ReVanced/revanced-patches#1454)) ([fd782aa](ReVanced/revanced-patches@adb2130))
* **youtube:** `spoof-app-version` patch ([ReVanced#1449](ReVanced/revanced-patches#1449)) ([bd4d3b5](ReVanced/revanced-patches@37d0465))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.154.0](ReVanced/revanced-patches@v2.153.0...v2.154.0) (2023-01-13)

### Bug Fixes

* **youtube/hide-info-cards:** allow toggling visibility of info-cards ([ReVanced#1464](ReVanced/revanced-patches#1464)) ([e6dcb55](ReVanced/revanced-patches@cb89688))

### Features

* `remove-screenshot-restriction` patch ([ReVanced#1455](ReVanced/revanced-patches#1455)) ([a16ab79](ReVanced/revanced-patches@5c1cd0b))
* **music:** update patches compatibility to v5.38.53 ([ReVanced#1453](ReVanced/revanced-patches#1453)) ([c7d116a](ReVanced/revanced-patches@3d316e9))
* **music:** update patches compatibility to v5.39.52 ([ReVanced#1484](ReVanced/revanced-patches#1484)) ([81d6527](ReVanced/revanced-patches@fe05091))
* **tiktok:** update patches compatibility to v27.8.3 ([ReVanced#1483](ReVanced/revanced-patches#1483)) ([e72b3bd](ReVanced/revanced-patches@51d1f21))
* **youtube/return-youtube-dislike:** style for minimum width ([ReVanced#1454](ReVanced/revanced-patches#1454)) ([fd782aa](ReVanced/revanced-patches@adb2130))
* **youtube:** `spoof-app-version` patch ([ReVanced#1449](ReVanced/revanced-patches#1449)) ([bd4d3b5](ReVanced/revanced-patches@37d0465))
@oSumAtrIX
Copy link
Member

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long
  • Low priority
  • Maintainers un-interested
  • Too complex to realize

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants