Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(YouTube - Copy video url): Redesign share video timestamp icon #157

Closed
3 tasks done
GKid94 opened this issue Oct 28, 2023 · 7 comments · Fixed by #2982 or #3023
Closed
3 tasks done

feat(YouTube - Copy video url): Redesign share video timestamp icon #157

GKid94 opened this issue Oct 28, 2023 · 7 comments · Fixed by #2982 or #3023
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@GKid94
Copy link

GKid94 commented Oct 28, 2023

Bug description

The share time button needs a design change because it's hard to see what the button is for
IMG_20231028_220743

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@GKid94 GKid94 added the Bug report Something isn't working label Oct 28, 2023
@LisoUseInAIKyrios
Copy link
Contributor

When the button is pressed It shows a toast. The user will figure it out after they try it.

@oSumAtrIX
Copy link
Member

I agree with @LisoUseInAIKyrios, though the user may be too hesitant to click on things they don't know, so it may be considerable to change it. Please make suggestions

@GKid94
Copy link
Author

GKid94 commented Oct 28, 2023

When the button is pressed It shows a toast. The user will figure it out after they try it.

Toast?

@KobeW50
Copy link
Contributor

KobeW50 commented Oct 29, 2023

Toast?

Screenshot_20231028_201803.jpg

@GKid94
Copy link
Author

GKid94 commented Oct 29, 2023

Toast?

Screenshot_20231028_201803.jpg

Oh ok

@MondayNitro
Copy link

Screenshot_20231030-141150_Trebuchet
The clock is better visible in inotia's icon

@GKid94
Copy link
Author

GKid94 commented Oct 31, 2023

Screenshot_20231030-141150_Trebuchet The clock is better visible in inotia's icon

This looks better 👍

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: Redesign time share button feat(YouTube - Copy video url): Redesign share video timestamp icon Nov 5, 2023
@LisoUseInAIKyrios LisoUseInAIKyrios added Feature request Requesting a new feature that's not implemented yet and removed Bug report Something isn't working labels Nov 5, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
@TheJeterLP TheJeterLP mentioned this issue Dec 14, 2023
Closed
@MarcaDian MarcaDian mentioned this issue Apr 14, 2024
Merged
This was linked to pull requests Apr 18, 2024
chore: Merge branch dev to main #2982
Merged
feat(YouTube): Match overlay icons style to YouTube #3023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Milestone
No milestone
5 participants
@oSumAtrIX @GKid94 @KobeW50 @MondayNitro @LisoUseInAIKyrios