Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: In certain devices, gesture volume goes up to 150, instead of 15. #1646

Closed
3 tasks done
d3EyedRaven opened this issue Dec 5, 2022 · 19 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@d3EyedRaven
Copy link

Type

Other

Bug description

On certain devices (I have Redmi Note 10 Pro), the volume with gestures enabled goes up to level 150 instead of 15. The drag speed is also same as level 15, so in one drag maximum volume I can change is 30. That's 5 full drags to change from min to max volume and max to min.

Steps to reproduce

  1. Enable gesture for brightness and volume

  2. Use volume gesture to increase or decrease volume

  3. Instead going through level 0 through 15, it goes 0 through 15 with same slow drag speed.

Relevant log output

sorry not available

Screenshots or videos

No response

Solution

Currently it's 100 levels for brightness with high drag sensitivity, and 15 levels for volume with low drag sensitivity.

I think it's fair to do 30 levels of brightness and volume in all devices, as in MX Player, (or 100 as in VLC Android) for the same drag sensitivity.

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@d3EyedRaven d3EyedRaven added the Bug report Something isn't working label Dec 5, 2022
@SodaWithoutSparkles
Copy link
Contributor

SodaWithoutSparkles commented Dec 5, 2022

Unable to replicate the volume goes up to 150 issue. Currently on:

  • POCO X4 GT
  • MIUI 13
  • Android 12
  • Revanced YT 17.45.36
  • Manager 0.0.43
  • Patches 2.137.0

Can you submit a screen record as proof? Theres a built-in screen recorder on MIUI devices, but remember to keep it at ≤30fps and short, as GitHub only allows videos up to 10MB

@oSumAtrIX
Copy link
Member

This depends on your phone

@d3EyedRaven
Copy link
Author

d3EyedRaven commented Dec 5, 2022

@SodaWithoutSparkles

done
Redmi Note 10 Pro
all configuration same as yours.
(youtube lagged when capturing uploaded video)

thread of other user with same issue: https://www.reddit.com/r/revancedapp/comments/z0vzul/it_takes_around_7_to_8_swipes_to_increase_volume/

Screenrecorder-2022-12-05-21-22-58-591.mp4

@SodaWithoutSparkles
Copy link
Contributor

okay... looks strange indeed. Can you enable the show touch option in screen recorder?

BTW, whats that video? I want to have a sample to see if it is spectific to portrait video being played in landscape

@oSumAtrIX
Copy link
Member

Its not strange as previously implied, because his phone only has this many steps for volume.

@d3EyedRaven
Copy link
Author

d3EyedRaven commented Dec 5, 2022

Hi @SodaWithoutSparkles
Link to first video: https://youtu.be/rz1Ad5Yizbk

New video that's fully landscape: https://youtu.be/iZnLZFRylbs

Screenrecorder-2022-12-05-22-07-42-450.mp4

As @oSumAtrIX mentioned, my phone has indeed that many steps for volume i.e. 150, however i couldn't find solution to that.

Is this possible?

I think it's fair to do same levels of brightness and volume in all devices, 30 as in MX Player, or 100 as in VLC Android for the same swiping sensitivity.

@SodaWithoutSparkles
Copy link
Contributor

ok. does using the OG youtube, (with the same version,) has this problem as well?

I dont think theres any way for a android phone to have volume over 15. Thats certainly abnormal. Maybe it will be converted from 0-150 to 0-15 scale?

Can OP also monitor the volume by the system volume meter? Press volume once, then swipe the volume, observe if the bar changes as well. But be quick, the bar would disappear in less than 3 seconds

@d3EyedRaven
Copy link
Author

d3EyedRaven commented Dec 5, 2022

pressing volume button changes the volume using 0-15 scale. swiping changes the volume using 0-150 scale.

at one point i had just kept the volume swiping off just because of low swiping sensitivity.

@SodaWithoutSparkles

this problem only occurs in revanced youtube. None other application, including stock youtube, latest version.

update: I just tried vanced youtube using vanced manager, it had same issue, but at least swiping sensitivity is fast, same as brightness swipe. had to swipe once or twice to get to max volume instead of six swipes at revanced.
i also tried turning miui optimizations off like vanced manager asked me to, it didn't help.

@maghuro
Copy link

maghuro commented May 11, 2023

Didn't happened on my Xiaomi 10T pro, and now it's happening in my 12T pro - 150 steps to boost volume, even if pressing the volume buttons!

Is there something I have to change? I can't find anything.

@SodaWithoutSparkles
Copy link
Contributor

@oSumAtrIX it does depends on the phone, but the user just sees the 0-15 UI. They dont see the 0-150 UI in anywhere except revanced/old-vanced. Maybe a workaround can be installed, like IF the range is 0-150, then jump for 10 units at once instead of 1

@LemonadeG

This comment was marked as spam.

@LaundryHamper
Copy link

I also have this issue. My phone is a Xiaomi Redmi Note 10 Pro (...2 Alpha HD Remaster & Knuckles: The Lost Levels), so it isn't a device-specific issue, it's specific to MiUI, and it's an issue which can be accounted for and avoided by the application. Whatever way volume control was implemented in Vanced resulted in the normal 0-15 scale on this same phone. ReVanced has the 0-150 scale, but only when the video is playing in fullscreen.

Reddit is Fun also has this issue, but again only when a video is fullscreen.

Vimeo does not have this issue, even when fullscreen.

It probably has something to do with Xiaomi wanting MiUI's floating volume sliders to appear infinitely scalable like those on the iPhone.

On top of how annoying to use this makes the swipe gesture, it takes slightly more than eight seconds to go from one end of the scale to the other holding down the volume button, which isn't great if you need your phone to shut up in a hurry.

@SodaWithoutSparkles
Copy link
Contributor

SodaWithoutSparkles commented Jun 16, 2023

@LaundryHamper Can you try executing termux-volume in termux? You probably need termux:api as well.

https://f-droid.org/packages/com.termux
https://f-droid.org/packages/com.termux.api

if the packages are missing, install them as prompted.

Example output:

[
  {
    "stream": "call",
    "volume": 11,
    "max_volume": 11
  },
  {
    "stream": "system",
    "volume": 8,
    "max_volume": 15
  },
  {
    "stream": "ring",
    "volume": 8,
    "max_volume": 15
  },
  {
    "stream": "music",
    "volume": 9,
    "max_volume": 15
  },
  {
    "stream": "alarm",
    "volume": 10,
    "max_volume": 15
  },
  {
    "stream": "notification",
    "volume": 8,
    "max_volume": 15
  }
]

What i am interested in is the max_volume number. Does the OS reports the correct one or a wrong one?

@dev0nizer
Copy link

Looks like a Xiaomi related bug, my device is Xiaomi Pad 6 and I'm facing the same issue
Also, the status of the issue is "closed", but there is no solution :(

@SodaWithoutSparkles
Copy link
Contributor

@dev0nizer try the termux thing i mentioned above. Wanna get some more insights

@dev0nizer
Copy link

@SodaWithoutSparkles apologies for the late response

[
  {
    "stream": "call",
    "volume": 8,
    "max_volume": 11
  },
  {
    "stream": "system",
    "volume": 10,
    "max_volume": 15
  },
  {
    "stream": "ring",
    "volume": 10,
    "max_volume": 15
  },
  {
    "stream": "music",
    "volume": 75,
    "max_volume": 150
  },
  {
    "stream": "alarm",
    "volume": 12,
    "max_volume": 15
  },
  {
    "stream": "notification",
    "volume": 10,
    "max_volume": 15
  }

@SodaWithoutSparkles
Copy link
Contributor

So it does report the 150 number. @oSumAtrIX maybe add a sensitivity option for swipe controls?

@dev0nizer
Copy link

@SodaWithoutSparkles changing volume with buttons is also extremely slow (I need to hold the "volume down" button for 3-4 seconds to change the volume from 150 to 0), so it would be great to have a scale control for both buttons and swipe gestures, or implement some other fix

@clicky6
Copy link

clicky6 commented Dec 1, 2023

Any module or hack which can make the the volume steps that are currently 15 on my device in Revanced to 100 or 150?

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.163.0-dev.2](ReVanced/revanced-patches@v2.163.0-dev.1...v2.163.0-dev.2) (2023-02-19)

### Features

* **twitter:** constrain patches compatibility to working versions ([ReVanced#1646](ReVanced/revanced-patches#1646)) ([d984bdc](ReVanced/revanced-patches@f75e825))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.163.0](ReVanced/revanced-patches@v2.162.0...v2.163.0) (2023-02-22)

### Bug Fixes

* **tiktok/show-seekbar:** fix crash when showing seekbar ([ReVanced#1643](ReVanced/revanced-patches#1643)) ([160b716](ReVanced/revanced-patches@c7e1d34))
* **twitter:** make `hide-promoted-ads` patch compatible with any version ([3dbc5ff](ReVanced/revanced-patches@466d31d))
* use correct fingerprint ([84fe9c3](ReVanced/revanced-patches@948f905))
* **youtube/disable-fullscreen-panels-auto-popup:** use proper descriptions ([4c82487](ReVanced/revanced-patches@50363c9))
* **youtube/general-ads:** fix switch description wording ([9003977](ReVanced/revanced-patches@c27b5f7))
* **youtube/hide-time:** use correct integrations class ([539ccf4](ReVanced/revanced-patches@be8058c))
* **youtube/hide-watch-in-vr:** fix descriptions ([f261e64](ReVanced/revanced-patches@24cfbeb))
* **youtube/open-links-directly:** reference correct integrations method ([e14893e](ReVanced/revanced-patches@33b18da))

### Features

* **androidtwelvewidgets:** `unlock-paid-widgets` patch ([ReVanced#1641](ReVanced/revanced-patches#1641)) ([44b74ae](ReVanced/revanced-patches@113ef0f))
* **music:** remove patches constraint on app version ([ReVanced#1638](ReVanced/revanced-patches#1638)) ([fe64881](ReVanced/revanced-patches@480c916))
* **twitter:** `hide-recommended-users` patch ([e8c9a91](ReVanced/revanced-patches@bd32f1d))
* **twitter:** constrain patches compatibility to working versions ([ReVanced#1646](ReVanced/revanced-patches#1646)) ([d984bdc](ReVanced/revanced-patches@f75e825))
* use better patch descriptions ([931aa0f](ReVanced/revanced-patches@719eda6))
* **youtube/general-ads:** hide channel bar ([c74c77d](ReVanced/revanced-patches@e000d09))
* **youtube/general-ads:** hide horizontal video shelf ([169e2ba](ReVanced/revanced-patches@2d150b3))
* **youtube/open-links-directly:** skip every redirect url ([f155e26](ReVanced/revanced-patches@5cadd95))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants